WordPress / community-themes

A collection of Block Themes built by the WordPress community.
80 stars 33 forks source link

Blue note: Styles #60

Closed MaggieCabrera closed 1 year ago

MaggieCabrera commented 1 year ago

I thought I had done this one but it looks like I didn't!

Let's make sure that theme.json defines the global styles for the theme correctly using this as a guide. If the templates suggest that these numbers are wrong, let's follow the templates over this.

Styles

carolinan commented 1 year ago

I tried adding the secondary color to the links active and focused state but in my opinion the color contrast between the background and link color is too low: Contrast Ratio: 2.01:1.

To my knowledge, this does not pass WCAG 2 AA because there is no change in the text decoration. If for example the underline was also changed, then if I remember correctly, it would technically pass. Edit: For focus, the focus outline might be enough.

carolinan commented 1 year ago

For the buttons, I tried styling the variations so that button one would be the "outline" style variation and button two would be the default. But styles > blocks > block name > variations > variation name does not support: