search

WordPress / community-themes

A collection of Block Themes built by the WordPress community.
80 stars 33 forks source link

Standardise spacing between Header and Main Content across all templates #73

Closed getdave closed 1 year ago

getdave commented 1 year ago

Many Issues mention spacing between the Header and the Main Content (often referred to as "the Heading" in the Issues).

Instead of correcting on a per template basis let's just set a bottom margin on the Group within the Header part.

As this is a vertical spacing we should base on the viewport width so that it scales appropriately.

Ideally we'd be able to clamp this to a min-max but I don't think that's possible...it is?

Part of https://github.com/WordPress/community-themes/issues/11

richtabor commented 1 year ago

This makes sense but I think we should use one of the presets

You could set min/max with spacing presets like this: https://github.com/richtabor/wabi/blob/main/theme.json#L183

scruffian commented 1 year ago

Tried that here: https://github.com/WordPress/community-themes/pull/77

getdave commented 1 year ago

We should merge Ben's PR and then rebase this to use that.