Closed scruffian closed 1 year ago
This feels like exactly how we should be building Themes. Spacing, especially vertical spacing, should adapt to viewport up to a max setting. It should "just work" at all sizes no matter which size you "design" the Theme on.
Thank you đź‘Ź
I'll defer to more experienced theme designers for review.
I decided to just make the changes to the presets in the theme json. The slugs now match more clearly to pixel values, e.g.:
--wp--preset--spacing--60
is 60px
I agree with this approach, I just wonder if we should tweak the
vw
numbers. I was mainly looking at the spacings for the header and they seem to vary very little when looking at really small viewports, so it's barely noticeable that the spacing is fluid at all.
Yea they should be improved (and consolidated a bit). I don’t think 9 and 10 are used at all, you’d just to combine two spacing values that are close and then you’d have the proper spacing RangeControl.
This updates Blue Note to use fluid spacing.
These presets are slightly larger at smaller screen sizes, so I have downsized all of the presets too, to keep the spacing about the same. It's not an exact science though!