search

WordPress / community-themes

A collection of Block Themes built by the WordPress community.
80 stars 33 forks source link

Blue note: Search form styles #88

Closed MaggieCabrera closed 1 year ago

MaggieCabrera commented 1 year ago

I think this is the only thing missing to close https://github.com/WordPress/community-themes/issues/11

scruffian commented 1 year ago

We should probably look at the no results variation too:

Screenshot 2023-08-02 at 11 40 53

I also find the left aligned search field very strange.

MaggieCabrera commented 1 year ago

I don't hate it if the heading is to the left too. It's how it was on figma. The different size does bug me though.

scruffian commented 1 year ago

The featured image is sometimes too small as well...

Screenshot 2023-08-02 at 11 48 28
MaggieCabrera commented 1 year ago

The featured image is sometimes too small as well...

Do you mean it should have the aspect ratio applied?

MaggieCabrera commented 1 year ago

I think we should do the aspect ratio thing anyway since the featured image is not the same size in the three places that it shows: the home template, the archive/search and the single template. We should also add aspect ratio to the header-large pattern now that I think about it.

MaggieCabrera commented 1 year ago
Screenshot 2023-08-03 at 10 04 32

I don't think we will see many cases where index/archive will show the no results text, so I changed it so it doesn't show a second h2 and a second search block. Also added the aspect ratio.