WordPress / create-block-theme

A WordPress plugin to create block themes
https://wordpress.org/plugins/create-block-theme/
GNU General Public License v2.0
310 stars 44 forks source link

Update package-lock.json #620

Closed t-hamano closed 1 month ago

t-hamano commented 1 month ago

I noticed that when I run npm ci on the latest trunk, package-lock.json gets updated. I think this is because only @wordpress/env in package.json was updated in #619.

Testing Instructions

t-hamano commented 1 month ago

Thanks for the testing.

I tried regenerating package-lock.json, but does the difference still occur? By the way, if you run npm i on trunk, does a diff occur?

mikachan commented 1 month ago

I tried regenerating package-lock.json, but does the difference still occur?

Yes, although not as many differences - the difference with playwright/node_modules/fsevents is not happening anymore, but the others still are (playwright and typescript). I can push my package-lock so you can see the differences if you like?

By the way, if you run npm i on trunk, does a diff occur?

Yes, I see a lot of changes in my package-lock on trunk.

t-hamano commented 1 month ago

I can push my package-lock so you can see the differences if you like?

Yes, I would appreciate it if you could push it. Your Node version is 20, right?

mikachan commented 1 month ago

I've just pushed it here: https://github.com/WordPress/create-block-theme/pull/620/commits/3a65a352ead8d81b42c8d241140ce167c78b723d

Your Node version is 20, right?

Yes, I'm using v20.12.2.

t-hamano commented 1 month ago

Check out the latest commits on this branch and I tried running npm i again, but the diff still occurs 😅 My Node version is also 20.12.0. Could you tell me the npm version? My npm version is 10.5.0.

mikachan commented 1 month ago

My npm version is v10.5.0 too! I'm happy to go with your package-lock version, I don't think it's a big deal, but it's confusing why they're different 😅

t-hamano commented 1 month ago

I don't understand why there is a difference since the npm version and node version are exactly the same 😅

I tried regenerating package-lock.json again. Could you running the following on this branch?

rm -rf node_modules/
npm cache clear --force
npm install

If it doesn't resolve the issue, it might be better to close this PR...