Closed pbking closed 1 month ago
I removed the Remove
button as I don't think that the screenshot should ever not be there.
@pbking Thank you for your quick implementation! I would like to test the backend a little more, but first I made some adjustments to the UI. What do you think? Are the buttons a little too noticeable?
Before | After |
---|---|
What do you think? Are the buttons a little too noticeable?
I think they are fine either way. I like the option you just pushed slightly better though.
👍
It works great. I have observed one minor issue with image size. Tried uploading following image
It previews screenshot differently.
We should probably consider both ratio 4:3
and max size 1200x900
while resizing ?
Hrm 🤨
Regarding the wide image... The size restrictions are noted as a MAXIMUM of 1200 x 900. Which the image fits in. The original is less than 900 pixels tall. I believe that the cropping/resizing is acting as I would expect.
I tried another image that was very wide, but over 900 px tall (2500 x 1200) and it cropped and resized to the expected 1200 x 900 size.
There might be a better way to handle this edge case (upscaling the image maybe? then cropping it?) but I don't think it's worth the effort (when a user should really be providing an image of the appropriate dimensions anyway...)
If you believe that we should consider addressing that further would you mind opening an issue to explore additional solutions @madhusudhand ?
Add ability for user to manage the theme's screenshot from Editor on Metadata Modal.
Fixes: #560
To Test:
The image should be replaced in the theme folder and sized to 1200 x 900 px.
If a screenshot existed prior it should be removed. (Especially if the previous screenshot was another file type)