Fix: Version field not updated - Githubissues

WordPress / create-block-theme

A WordPress plugin to create block themes

https://wordpress.org/plugins/create-block-theme/

GNU General Public License v2.0

310 stars 44 forks source link

Fix: Version field not updated #640

Closed t-hamano closed 1 month ago

t-hamano commented 1 month ago

I noticed that the version field was not taken into account in the sanitize_theme_data method, so we couldn't update this field.

This PR should also resolve the following PHP error that is logged when updating metadata.

PHP Warning:  Undefined array key "version" in /var/www/html/wp-content/plugins/create-block-theme/admin/create-theme/theme-styles.php on line 20

Testing Instructions

Opne the Edit Theme Metadata modal.
Update "Version" field.
Open style.css in your active theme and check the Version: header data.

pbking commented 1 month ago

I've fixed the same in this PR which also fixes some other values that get clobbered.