search

WordPress / create-block-theme

A WordPress plugin to create block themes
https://wordpress.org/plugins/create-block-theme/
GNU General Public License v2.0
310 stars 44 forks source link

Make external links translatable #663

Closed t-hamano closed 1 month ago

t-hamano commented 1 month ago

This PR applies a translation function to some external links, since they may be locale-specific.

However, the following links remain unchanged:

https://github.com/WordPress/create-block-theme/blob/eabd38201d6a7cbb1631be4cf9eae820fe838028/src/landing-page/landing-page.js#L193 https://github.com/WordPress/create-block-theme/blob/eabd38201d6a7cbb1631be4cf9eae820fe838028/src/landing-page/landing-page.js#L206

GitHub URLs are the same regardless of locale.

https://github.com/WordPress/create-block-theme/blob/eabd38201d6a7cbb1631be4cf9eae820fe838028/assets/boilerplate/parts/footer.html#L6

Currently it is not possible to make strings in HTML templates translatable. See the following core ticket for more information: https://core.trac.wordpress.org/ticket/60298

t-hamano commented 1 month ago

Thanks for the review!