Fix incorrect menu-alt unicode address.

[adiloztaser]

When I was investigating why the mobile menu icon is not displaying properly in 5.2-alpha, I realized the icon unicode location is not as the old font was.

https://core.trac.wordpress.org/ticket/46611

[jasmussen]

Nice patch, thank you.

The new unicode address after this patch is 61992 in decimal, and f228 in utf-16.

The previous unicode address was 61707, which looks to be sequential after the previous icon, email-alt2, which could suggest we simply forgot to apply the correct icon address. This converts to f10b in utf-16.

Two tasks now:

1. Let's verify that f228 is the correct address, and not f10b.
2. Let's verify, just to be sure, what the address of email-alt2 was as well, and be sure that's correct. It looks auto generated, which could be fine, but let's be sure.

I reinstalled Glyphs Mini and opened the old Dashicons font, and it looks like this patch is correct:

But it looks like the hunch about email-alt2 was also correct :( it's f10b in the new font, and f465 in the old font:

It seems like it would be good for us to do a 1:1 comparison of ever icon in the old and the new font, and match the unicode addresses. I've a bit on my plate so could use some help here, it would probably go something like this:

1. Download a font editor. I use Glyphs Mini, but I would wager https://fontforge.github.io/en-US/ works as well.
2. Open the new font (from here https://github.com/WordPress/dashicons/blob/master/icon-font/fonts/dashicons.ttf) and the old font (here's a copy: https://cloudup.com/cGMYeeOQbGD)
3. Compare unicode addresses, with the old version as the source of truth

I would suspect nearly all of the icons in the new font are in the correct addresses. But we should verify.

CC: @desrosj

[jasmussen]

Okay here's investigative work:

Icons that are new (and therefore codepoint doesn't matter):

• admin-site-alt
• admin-site-alt2
• admin-site-alt3
• businessperson
• businesswoman
• color-picker
• editor-ol-rtl — the vectors in this one are broken
• instagram
• rest-api — the vectors in this one are broken
• tide
• yes-alt

Icons that are missing or weird:

• [x] a duplicate arrow-ip at F143
• [x] unused-camera-alt is in svg-unused but should be at F129
• [x] "cloud" is mapped to F176 in old, appears as 2601 in new font
• [x] "minus" is f460 in old, is 2212 in new
• [ ] there's a new "plus" icon in 002B in the new font, that doesn't appear needed or used in the old font
• [x] "calendar" is f145 in the old font, is 1F4C5 in the new
• [x] "camera" is F306 in the old, 1F4F7 in the new
• [x] "clipboard" is F481 in the old, but 1F4CB in the new
• [x] "hammer" is F308 in the old, but 1F528 in the new
• [x] there's some issues with "lock" — there's a "lock-alt" in svg-unused that gets included at address 1F512 in the new font, and there's a very similar but more rounded looking lock icon at F315 in the old font. We should figure out WHICH lock icon is the right one, delete the unused ones, and map the result to F315 in the new font.
• [x] F302 contains a very obsolete version of the Twitter logo. This is stored in svg-unused, and is not part of the new font.
• [x] microphone is at F482 in the old font, and at 1F3A4 in the new font.
• [x] there's a little chunky menu icon at F329 that does not appear to be part of the new font. It's "unused-menu"
• [x] "paperclip" is at F546 in the old font, and 1F4CE in the new
• [x] "plugins-checked" from unused folder is at F485 in the old font, does not appear in the new
• [x] "text-page" is at F121 in the old, does not appear in the new
• [x] "update" exists in two versions. the one from the unused folder maps to F113 in the old font, doesn't appear in the new. But "update", which is mirrored appears at F463 in both fonts

NOTE that some of the above icons are currently stored in svg-unused, but since they ARE actually used they should be moved out of that folder

Codepoints that need fixing:

• [x] buddicons-bbpress-logo, should be F477, is F12B
• [x] editor-ltr, should be at F320, is at F129
• [x] editor-rtl needs a sanity check, it points leftward in new font, rightwards in old font
• [x] email-alt2 is F10A, should be F467

Next I'll try to take a stab at these codepoints, though note there are still some questions in the above that need answers.

---

Duplicate icons in the old:

Missing camera from the new:

Broken rest api icon:

Broken editor-ol-rtl icon:

Missing chunky menu icon:

obsolete twitter icon:

Editor RTL/LTR in the new font:

Editor RTL in the old:

[jasmussen]

350 tries to fix the above.