Closed bph closed 1 year ago
Here's how we can break this down into posts:
Draft is here: https://docs.google.com/document/d/1WpVmVjaExxlf8hGt-x0xN_jsrbbG9141gP5qlM46AlE
I'm thinking about two things:
-Or, should a condensed version of it be an intro to every post?
I also wonder if this post is a tad long, and should be maybe two posts ...
@marybaum It's a great post, learn a lot! and I am looking forward to laying out all the things when it comes to publishing.
It feels more like a pre-beginners "Typography tutorial on terms and stuff" (you are the wordsmith here) . As that it's has a great length.
It's ok to have this as a first post. What I am missing is the overall picture, aka note on that this is the start of a series, and what other posts are planned. If you list them, we can make this a reusable block (aka synched pattern) and add it to the top and bottom of subsequent posts, with the links to the other parts.
Something like the "This is the start of a great adventure, and we are cruising the typography space, how it applies to modern WordPress development, we start with the basics as design language can be a bit confusing and new tools coming to WordPress."
What an advanced reader/designer might find missing is the accompanying theme.json vocabulary to all the typography terms and identify the onces that are not yet configurable, and need CSS love instead. You might want to mention that it will be part of Part 2 or 3 or so.
It's a bit unfortunate that the Fonts API won't make it into 6.3 yet, but that also gives us time to test things throroughly and start writing that piece when there is soemthing to write about. But it also could be listed in the parts that are planned.
Note: I didn't not do a 1st review on the copy, though. Maybe @abhansnuk or @justintadlock could assist there.
I've been away on vacation for a week and a half. Jumping in now...
I appreciate that you avoided the default Google Docs font size used and used something comfortable enough for reading. That made for a promising start to an article on typography. :)
I'm not much of a copyeditor, but I can usually find a problem or two. That wasn't the case here. Well done! I did note a couple of spots where the text didn't reflect what was in the image.
Also, TIL what a "superfamily" was.
The post isn't too long. I think I'd use the opener for this discussion as the intro in the post. Introduce this as a series.
Other than that, it looks good to move forward.
Thanks very much for the review! I agree that it needs the intro, and I think I'll also add a list of the posts, maybe in a reusable block. I mean, synced pattern. 😜
Okey dokey! Ready for second review, still in the Google doc.
https://docs.google.com/document/d/1WpVmVjaExxlf8hGt-x0xN_jsrbbG9141gP5qlM46AlE/edit
This looks good to go to me. I deleted an extra space in the doc, but that's it. I'll post in the Dev Blog Slack for someone else to "officially" sign off on this since I was technically involved in the first review.
@marybaum are you ready to post it to the site? 2nd review is also a formatting review to see how it behaves on site... or maybe that's the 3rd review?
I am! I did want to see how adding the intro felt to me in pure content terms. But it can go on the p2 now!
Oh, the added insight into what the series is about reads very well now, and ties it nicely together..
I switched the post to the Centered Column template.
Did you add a new Visual Design category? That should probably be a tag. I don't know if we have anything official on it yet, but I think we want to keep the categories pretty limited (they're used in the nav bar). It probably wouldn't hurt to have a more all-encompassing "Design" category, though.
Otherwise, it looks good to go.
Totally concur with @justintadlock 🚢
You should be ok re: Publishing , here is to double-check:
Discussed in https://github.com/WordPress/developer-blog-content/discussions/100