Closed justintadlock closed 1 month ago
@justintadlock Happy to take this one on.
Ooops! Accidentally assigned it to myself there for a second. :)
@n8finch - Thanks for taking this on. Feel free to ask me for any help or anyone from the #core-dev-blog Slack channel about getting started.
Here's a list with important links for contributing:
The biggest thing is to put your draft (when you start it) in a Google Doc that has open comments/suggestions and leave the link to it here. The review process will happen within the doc.
Hey folks, just a quick update, here's the outline for the tutorial:
create-block
to get a single block--no-plugin
, rearrange files, multi block is readyIt's "in development" right now, but the idea is to build out a block with an inner block with limitations on where the block should be used.
I'll get a POC up soon to a repo for review, should be in the next two weeks, maybe sooner.
Is there a "due date" for this? (cc @bph ) or just "sooner rather than later" π
Do you also want a screencast video with this? I'm happy to do that as well.
@n8finch Thank you. This looks really good. Can't wait to read it. I really like the example idea.
A screencast supporting the written instructions and insights would be great, but the article should be able to stand alone.
A for a due date: Contributors pick their due date, as you know your calendar and your other workload. Once you pick a date, you can publicly share it here, and we can check in on your progress and send a reminder or so.
"Sooner rather than later" works, too.
@n8finch How are you doing? It's been a while. What is your timeline for getting a first draft, that can be reviewed?
@bph I'm so sorry, this had fallen off my radar. I think if possible, I'll need one more week, I'm most of the way through the code (not a lot left to do there), and then just write it up.
Awesome! Looking forward to ready your draft.
Here are a few links to get started:
@bph sorry for the delay, code is here, should have the draft finished tomorrow.
@bph ok, the draft is here: https://docs.google.com/document/d/1nxBUO6fla1xli-DVBLK7c7lVtfmKra5AVI-YilEtqIc/edit?usp=sharing
What do I need to do to get you or anyone else access as an editor? I've made anyone with the link a Commenter.
@n8finch Thank you! I am fine being a commenter and leave edit suggestions. I will be reviewing the post tomorrow, depending on your schedule, and availability of 2nd reviewer, we could aim for a publishing date for next week.
It's a great article and teaches quite a lot. Thank you, @n8finch, I am done with the first review. Left quite a few suggestions and comments. Ping me on WP Slack (DM or in #core-dev-blog channel) if you have questions.
@bph thank you so much for the in-depth review! I've made the updates and closed out all your suggestions. I've also added the repo to the WPTraining team: https://github.com/wptrainingteam/post-review-blocks
Let me know if I need to do anything else at the moment. π Otherwise, I'll hang tight for a 2nd review.
Hey @n8finch, great article. I went through and added a bunch of notes/suggestions π Please don't be daunted by the number of suggestions, it really is great. Let me know if you have any questions!
@ndiego thanks so much for the thorough review, not too much at all, could have been way worse π... I've got it all fixed up from your suggestions.
Let me know if anything else needs to be addressed. π (cc @bph )
@n8finch Although I tested your example code and it works well, I am a bit fuzzy on coding standards, so I ask @ndiego to take a second look at the technical details. In essence we teamed up on the first review. Reyes Martinez raised her hand to do the final "second review", I believe, later today.
I so appreciate your patience and your staying with this process. Thank you.
Hi @n8finch, great tutorial! I added some suggestions to the doc, they are mostly for very minor grammatical considerations or clarity and readability. Please feel free to accept or reject as you see fit. π
Nate, I sent you an invitation to the Developer Blog site. Once you are done with the feedback work, you can start posting it to the site.
Please enable the Public Post Preview feature and share the link in a comment here.
Here are the pre- and post-publishing checklists. (I am aware that you can't check of the list items. It's a permission thing on GitHub, I am working on. It will still be useful)
As this is your first post on the Developer Blog, I will double-check on these items, too and publish.
The site has a pattern for the Table of content and also provides a Notice block for call-out or special info or warnings.
@rmartinezduque thanks so much for the review! I really appreciate it!
@bph thanks for the invite, I'm in and will get to work on the check list. Haha, no, thank you and everyone else for your patience and help bringing this article to life. I'm really glad it's all coming together π.
@bph ok, I think it's ready!
Quick question: how big (dimensions) should the featured image be? The current Featured Image is 854 by 790 pixels. Happy to change it if it needs to be bigger, just let me know know the preferred or minimum dimensions.
Social copy:
Learn how to use 'create-block' to set up a multi-block plugin that uses InnerBlocks and post meta to create two blocks: a Rating block and a Review Card block. https://developer.wordpress.org/news/2024/05/20/setting-up-a-multi-block-using-inner-blocks-and-post-meta/
Anything else, let me know. Thank you! π
We haven't finalized the format standards yet for feature images. Here are notes I gave Ronny
npx create block
commands. They looked odd. There might be a bug in the list block as the bullet was on the second line of the second command, of the multi-line command. @n8finch once you update your featured image, go ahead and publish it. :-)
@bph got the feature image updated, woohoo! π
Whenever you're ready and available π π
π Congratulation @n8finch Your article is published now: Setting up a multi-blockΒ plugin using InnerBlocks and post meta
@bph Since the article is published, I've added props to slack.
Are the rest of the items on the list something you need to take care of?: add Props for reviews to #props channel in WP Slack ([Exam
Thank you so much for working on the article and through all the reviews :-) π All checklist items done!
Discussed in https://github.com/WordPress/developer-blog-content/discussions/186