Closed bph closed 1 year ago
Thanks @bph I'll pick this up.
Allowing conditionals on these filters would be nice as well. For example, if a user wants to disable specific settings only within "posts" since they typically require far less stylistic control.
This article is ready for first review: https://docs.google.com/document/d/1f64YAP90gjRtP0KgtjAx6wiBKuhRLT1dFUJTPAKLGDw/edit
Heading in! NIck, I do copy edits in suggestion mode โ Keep what works for you and broom what doesn't!
Thank you sooo much @marybaum ๐
Done! See what you think, and do your damnedest!
You'll notice maybe that my edits are mostly about changing passive verbs to active ones: from
The function is used to return this
to
The function does this...
And I add copious references to You, which is any reader's favorite person (themself ... ) to keep readers engaged and remind them they have skin is this game. I like to say we talk TO readers, not ABOUT them.
The third thing I do, generally, is use the shortest, most colloquial words possible. Because I want to connect with a reader viscerally, not cerebrallyโ I mean, in the gut, not the headโsince the gut is where things stick.
Thanks @marybaum, I greatly appreciate it. ๐
Excellent article, I had nothing to add a comment on. Great job!
Thanks for the review @mburridge
The public preview of the final draft is available.
@ndiego This is a great tutorial. I am tempted to write a few customization myself ๐
I found the compare image block a little hard to decipher. I tried to add additional instructions above, but found that it doesn'tmake it easier to see the two different variations, but it's makes it even more awkward....
I would use both image in the canvas as they are and add some caption to each. We have the space, and it's much clearer for the reader to see the difference right away.
Here again for you the two checklists before you hit the publish button.
@bph thanks for reviewing and good callout. I was trying to get too fancy with it ๐ I'll update the images as a two images gallery. I already updated the images at the beginning of the article and I think it works well.
The post has been published here: How to modify theme.json data using server-side filters
Thanks to everyone who helped out!
Discussed in https://github.com/WordPress/developer-blog-content/discussions/82