search

WordPress / five-for-the-future

Plugins and themes for the Five for the Future subsite
https://wordpress.org/five-for-the-future/
54 stars 25 forks source link

Theme: The child theme's `navigation.js` file is not used #156

Closed ryelle closed 2 years ago

ryelle commented 3 years ago

The child theme contains a navigation.js file, but then enqueues the navigation.js from the parent theme.

https://github.com/WordPress/five-for-the-future/blob/325a6d71e2d08533dc923af42fdfe1de17cd8468/themes/wporg-5ftf/functions.php#L128

See related issue in Learn: https://github.com/WordPress/learn/issues/204; and meta trac ticket to update the parent theme to correctly register this script: #5687-meta - then the child theme could just use wp_enqueue_script( 'wporg-navigation' ).

iandunn commented 2 years ago

Removed in 77faa74b059e2966e80bdd167b7aa0cc370fcb1c