search

WordPress / five-for-the-future

Plugins and themes for the Five for the Future subsite
https://wordpress.org/five-for-the-future/
44 stars 21 forks source link

Sanity check: skip sending emails for blocked accounts #221

Closed tellyworth closed 1 year ago

tellyworth commented 1 year ago

As a short-term fix while we're deciding how to handle #212, let's add some defensive code to the email cron job to skip sending to accounts that are blocked or have some other inactive status.

There's already some code for pruning unnotifiable teams, a similar check for unnotifiable users seems like it'd make sense.

dd32 commented 1 year ago

Just noting that there's other code in place on dotorg to skip sending emails to blocked members, so prior to this, the emails weren't actually going out.

iandunn commented 1 year ago

I think they were, we got several reports. Are you thinking of blocked domains instead?

dd32 commented 1 year ago

Are you thinking of https://github.com/WordPress/five-for-the-future/issues/212#issuecomment-1370297852 instead?

Huh.. yeah I am.. The blocked emails from this cron job were indeed from blocked domains.. I had thought we were blocking all emails to the banned accounts but I guess not.