search

WordPress / five-for-the-future

Plugins and themes for the Five for the Future subsite
https://wordpress.org/five-for-the-future/
44 stars 21 forks source link

Update PHPCS runner #253

Closed pkevan closed 2 months ago

pkevan commented 3 months ago

Currently the PHPCS feedback on PRs is virtually unusable, since it doesn't really indicate where the issue is within the code, so you have to guess where to alter things!

Screenshot 2024-05-21 at 12 31 56

Screenshot 2024-05-21 at 12 32 15

It appears like the methods used across repos aren't consistent, so that's probably a good place to start.

Example is from: https://github.com/WordPress/wordcamp.org

courtneyr-dev commented 3 months ago

Can you elaborate on the connection to this repo a bit more?

pkevan commented 3 months ago

The output is from: https://github.com/WordPress/five-for-the-future/actions/runs/9173862561/job/25223445480?pr=252 vs https://github.com/WordPress/wordcamp.org/actions/runs/8994333684/job/24707633432, and it's due to how the github workflow is setup.

https://github.com/WordPress/five-for-the-future/blob/production/.github/workflows/ci.yml#L46-L51

against

https://github.com/WordPress/wordcamp.org/blob/production/.github/workflows/linter.yml#L48-L50

courtneyr-dev commented 3 months ago

OH! Gotcha. Thanks for the connection :)

pkevan commented 2 months ago

Reconsidering this, since the output is accessible inline on the PR, so closing.