Fix build scripts for CSS, due to depreciation of `node-sass`

WordPress / five-for-the-future

Plugins and themes for the Five for the Future subsite

https://wordpress.org/five-for-the-future/

44 stars 21 forks source link

Fix build scripts for CSS, due to depreciation of `node-sass` #263

Closed pkevan closed 2 months ago

pkevan commented 2 months ago

Based on implementation in https://meta.trac.wordpress.org/changeset/11676

pkevan commented 2 months ago

@ryelle would you mind taking a look at this to see if I've missed anything?

The build works locally for me again, after struggling on apple silicon.

pkevan commented 2 months ago

I do get an extra change when i run npm run build though, I'm not sure if that's from my (outdated) environment or what. Do you also get this change?

Yes - I didn't want to add it to this PR as it wasn't necessary related, and seems like the change was added 5 years ago! I might add it in another PR just to sync the code.

I did wonder if we should be basing the repo off a different base theme, so maybe something else to consider.