search

WordPress / five-for-the-future

Plugins and themes for the Five for the Future subsite
https://wordpress.org/five-for-the-future/
53 stars 24 forks source link

Remove the admin actions in Organization pledge page #323

Open fcoveram opened 3 weeks ago

fcoveram commented 3 weeks ago

URL where issue is: Organization pledge

What do you see?

The Organization pledge page shows two actions related to admin permissions that might confuse ordinary and logged-in users.

Screenshot of admin actions in Organization pledge page

What should be changed?

Is it possible to hide the "Edit pledge" for not logged-in users? Keeping the report action visible all the time makes more sense, but also curious if there is a chance of moving it to another place.

If this topic was already discussed and concluded somewhere else, feel free to close it.

ryelle commented 3 weeks ago

Pledges are not attached to a user account (just a company email), so while we could hide it for non-logged in users, once logged in it will appear on all pledges. It also might not be totally clear that you need to log in to get to the edit link, since it isn't attached to an account.

I'm not against trying it out, that's just some extra context.

fcoveram commented 3 weeks ago

Thanks for the context

It also might not be totally clear that you need to log in to get to the edit link, since it isn't attached to an account.

I think that's fine.

I don't envision significant cases where orgs need to modify the pledge, and if so, admins and other org representatives could reach this action more easily than regular users. Adding friction to this flow seems reasonable to me.

ryelle commented 1 week ago

I'm dropping this issue back into "pending discussion" because I'd like some more feedback before hiding the button.

If we do this, a logged out user visiting the page has no indication on how to edit the pledge, not even that they should try again logged in.

Screen Shot 2024-10-01 at 14 11 27

Maybe the folks managing the pledges would always be logged in, and this is not a concern, but I don't know if we should rely on that. I don't want to generate extra support work for the folks managing this (cc @harishankerr)

Or we could add some kind of flow to the Manage Pledge page where you can visit that page directly and enter your pledge + email to get the link (related #259), and have people use that instead of the flow on the single pledge?