WordPress / five-for-the-future

Plugins and themes for the Five for the Future subsite
https://wordpress.org/five-for-the-future/
54 stars 25 forks source link

Show all contributors for a given team #69

Closed iandunn closed 4 years ago

iandunn commented 5 years ago

This will help team reps find people to work on projects

iandunn commented 5 years ago

It should probably include non-sponsored contributors too, though, so maybe it should live on the make p2s instead of here?

iandunn commented 5 years ago

Here's a rough wireframe of showing it on Make blogs, and the kind of info we might want to include:

Screen Shot 2019-11-04 at 12 18 21 PM

I'm thinking we'd automatically create a make.w.org/{team}/contributors page for each team, and include the above info for all the people (sponsored and not) who have marked that team on their profile.

If they're sponsored, the "Sponsored" links would go to their company's 5ftF pledge page. If not, we'd use the team "volunteer" to highlight that their contribution is even more significant than sponsored folks'.

We can't show only the # of hours that the contributor commits to the individual team, because we don't track that info on Profiles. We only track how much they commit across all teams.

In terms of functionality, does that sound good to people? @andreamiddleton, @melchoyce , @ryelle , @coreymckrill

andreamiddleton commented 4 years ago

Maybe just one tweak to the vocabulary:

make.w.org/{team}/pledges rather than make.w.org/{team}/contributors

If they're sponsored, the "Sponsored" links would go to their company's 5ftF pledge page. If not, we'd use the team "volunteer"

This seems like a good approach.

melchoyce commented 4 years ago

Would something like this work?

image

ryelle commented 4 years ago

Looks great, thanks!

I've marked this low priority for now since it's an enhancement to the make sites, not a requirement for Five for the Future directly.

iandunn commented 4 years ago

I'm making progress on this. Once it's done, how should we let people know that the new page exists? The two things that jump to mind are:

  1. Publishing a post on make/Updates
  2. Automatically add a widget to the bottom of each team's sidebar. It could show avatars like https://wordpress.org/five-for-the-future/pledges/, or just be a text link to the page.

I like the idea of doing both, because if we only write the make/Updates post, then most people won't be aware, because they don't read that site, and even those who do will eventually forget how to find the info and have to dig through old posts to find the link.

If we only do the sidebar widget, then most people will never notice that it's there.

If we do both, though, then I think the combination will create enough institutional knowledge to make it something that most active contributors are aware of.

Any thoughts?

iandunn commented 4 years ago

🤔 I'm second-guessing the idea to highlight volunteer contributors' extra sacrifice; I'm worrying that people might interpret that the opposite of how it's intended, like "they're only volunteering, so it's not a real contribution" ?

Part of that worry might be caused by the current copy explicitly saying "contribute" for sponsored folks, but only implying it for non-sponsored folks. Tweaking it to the following might help avoid that:

I still kinda worry that people might assume the worst, though 🤔

What do y'all think?

coreymckrill commented 4 years ago

I think using contribute for both instances helps.

iandunn commented 4 years ago

One thing that's become apparent while building this is that there are a lot of contributors on each team (mostly volunteer).

For example:

That's probably affected a lot by the inaccuracy of the self-reported data (see #83), but regardless, it'll make it pretty hard for team members to use the page for its intended purpose.

I wonder if we should add some filtering based on whether or not someone is sponsored, and/or sorting by hours contributed?

iandunn commented 4 years ago

Maybe another helpful filter would be an option to only show people who have the corresponding {Team} Contributor badge on their profile?

melchoyce commented 4 years ago

I think that would definitely help cut down on the inaccuracies — and encourage contributors to make sure they get properly credited!

iandunn commented 4 years ago

🤔 maybe that has contributor badge filter should be set in the default view, so that the user doesn't have to take any action to get the most useful data? But they could also switch over to the view all view to see everyone.

Maybe a doesn't have contributor badge filter would even be helpful for team reps to identify people who have contributed, but haven't been officially credited? That might be outside the scope of this page, or maybe just worth noting as a future iteration, but might be pretty easy to do 🤷‍♂

iandunn commented 4 years ago

The first parts of this are done in dotorg 15614 and https://meta.trac.wordpress.org/changeset/9320/.

e.g.,

It automatically exists for all of the Make sites that have a corresponding make_site CPT post.

I opened new issues for iterations: