search

WordPress / grunt-patch-wordpress

Patch Trac based projects
MIT License
50 stars 15 forks source link

Deprecate grunt-patch-wordpress #70

Open aaronjorbin opened 5 years ago

aaronjorbin commented 5 years ago

grunt-patch-wordPress has been an amazing tool, but it's time for it to move on. In order to do that, we need to get a successor in place. For that, we need to:

1) Remove the grunt dependency 2) Migrate the tests from mocha to jest ( see: https://gziolo.pl/2017/10/25/migrating-to-jest-test-runner/ ) 3) Use the wordpress/gutenberg scripts and styles 4) Move the codebase over to wordpress/gutenberg 5) ??? 6) Celebate the future.

It's possible that this repo can serve as a thin grunt wrapper around the replacement script.

kadamwhite commented 5 years ago

I consider 4 to be the lowest priority, vs removing the grunt dependency. 2 is accomplished in #71 and if I interpret 3 correctly that may be addressed by kadamwhite/grunt-patch-wordpress#1 (which can be targeted against this repo once #71 lands). I'm moving on to 1 now.

ntwb commented 5 years ago

Great proposal and thanks for creating it @aaronjorbin 💯

  1. This is in-line with #WP43731 to use npm for all the things
  2. I love Jest, thanks @kadamwhite
  3. & 4. There are a couple of options here, this module could become it's own with the Gutenberg monorepo packages as @wordpress/patch-wordpress or could become part of the existing @wordpress/scripts package

p.s. I just reviewed 72. before seeing this 😏 (Will look at 71 shortly)