search

WordPress / gutenberg-examples

Examples for extending WordPress/Gutenberg with blocks.
1.2k stars 316 forks source link

01-basic assets loading fix + WPCS #213

Closed tloureiro closed 2 years ago

tloureiro commented 2 years ago

The plugin is currently not working as is - it seems to be missing the wp-editor dependency. This PR should fix it

ryanwelcher commented 2 years ago

Thank you for taking the time to put this together!

We've made some pretty large structural changes to the repo one of which being that we no longer version the generated *.asset.php files.

Just to confirm, did you find this issue in the downloaded plugin on the release or the source code of this repo?

tloureiro commented 2 years ago

Thank you for taking the time to put this together!

We've made some pretty large structural changes to the repo one of which being that we no longer version the generated *.asset.php files.

Just to confirm, did you find this issue in the downloaded plugin on the release or the source code of this repo?

@ryanwelcher it was in the source code of the plugin

ryanwelcher commented 2 years ago

@ryanwelcher it was in the source code of the plugin

Thanks for clarifying. In that case, and based on the changes recently made to no longer version the build files, I'll close this out. Thank you for opening this PR and please feel free to do so for anything you run into moving forward!