search

WordPress / gutenberg-examples

Examples for extending WordPress/Gutenberg with blocks.
1.2k stars 315 forks source link

Updated the incomplete data basics repo to reflect the GB handbook how-to guide #227

Closed dgwyer closed 1 year ago

dgwyer commented 2 years ago

The data basics app on this repo was incomplete so I went through the handbook guide from start to finish and created the app from scratch.

I've also updated the how to guide via a separate PR: https://github.com/WordPress/gutenberg/pull/43633

adamziel commented 2 years ago

This. Is. Awesome! ❤️ It would be great to lint it to make the checks pass. I confirmed this compiles and looks good at the first glance. I'd like to test it in the browser after the linting just to be triple sure the tutorial gave all the right directions.🤞

adamziel commented 1 year ago

@dgwyer to lint the code examples I had to:

  1. Install the dependencies with yarn --ignore-engine install (npm install didn't work for me)
  2. Manually install the eslint plugin like yarn --ignore-engines add @wordpress/eslint-plugin@latest (cc @ryanwelcher )
  3. Run npm run format:js

I pushed the changes generated in step 3 to https://github.com/WordPress/gutenberg-examples/pull/235 in https://github.com/WordPress/gutenberg-examples/pull/235/commits/3e0acb75a8af3308ac3beac90fa8bc7e61a95b99

Note the CI still fails – I think it's broken for the entire repo at the moment and it's okay to ignore it for this particular PR.

I could merge #235 with you as the author, or you could add linting to this PR (#227) – whichever you prefer.

adamziel commented 1 year ago

@ryanwelcher just merged https://github.com/WordPress/gutenberg-examples/pull/235 which includes this plus the linting changes