Closed kjellr closed 4 years ago
I'm sure if this is a concern, but I only see "Header" under "Template parts" in the wp-admin.
But I see a "Footer" under the "Choose existing" option for template parts in the full site editor.
When adding the Footer, I see there's an invalid block? This "Attempt recovery" msg also was showing in the preview above.
I'm sure if this is a concern, but I only see "Header" under "Template parts" in the wp-admin.
For this one — no theme template files show up there. So anything you see there has been created on your local install.
When adding the Footer, I see there's an invalid block? This "Attempt recovery" msg also was showing in the preview above.
This on the other hand is likely a bug. 😄 I'll take a look.
When adding the Footer, I see there's an invalid block? This "Attempt recovery" msg also was showing in the preview above.
On second thought, I'm not seeing this on my install. 🤔
@jffng if you have a moment, would you mind giving this a try to see if I'm missing something?
The code change here, I don't see how it should be able to cause any issues that aren't issues in the block editor itself. That is to say if you find bugs, they are almost certainly some we need to fix in the project itself.
Also, this starter theme is so out of date, and I'm just delighted to see movement here. Ship this as fast as you can, and absolutely file tickets for anything you find.
This works in my testing (Gutenberg 8.6.1) as both a block-based and regular theme. I don't have repo permissions, but think this is worth merging. It's is a nice addition for anyone coming to this repo and hoping to get an idea for how to start adding FSE support to their theme.
Thank you everyone!
This PR adds some very basic block templates and template parts, along with a couple temporary styles to get them looking similar to the front end today. This lets folks start using the Full site editor with this theme today, but leaves things unchanged when the FSE experiment is turned off.
This is just a starting point. The next step would be to add an
experimental-theme.json
file.Testing
Gutenberg > Experiments
.Screenshots
Full-site editor: