WordPress / gutenberg-starter-theme

A simple theme for testing Gutenberg.
GNU General Public License v2.0
689 stars 168 forks source link

Add WordPress.org override styles #14

Closed melchoyce closed 7 years ago

melchoyce commented 7 years ago

Unsure if this should actually live in the theme or not, but I’ve added it here for record-keeping at least.

ntwb commented 7 years ago

Is this deployed on w.org?

It could be wrapped in a HTTP_HOST check, something along the lines of:

if ( false !== strpos($_SERVER['HTTP_HOST'], 'wordpress.org')) {
  wp_enqueue_style( 'gutenbergthemeblocks-style', get_template_directory_uri() . '/overrides.css');
}
melchoyce commented 7 years ago

Not deployed yet, no. Thanks for the suggestion! @obenland does that look good to swap into my PR ^ ?

obenland commented 7 years ago

We've been trying to base dotorg themes on a common parent theme that handles those style overrides. For Gutenberg I had those styles compiled and added to the regular stylesheet. If you want I could just append those there?

ntwb commented 7 years ago

That sounds like the way to go @obenland 👍

melchoyce commented 7 years ago

Yeah sounds good, thanks @obenland 👍

ntwb commented 7 years ago

This was committed in https://meta.trac.wordpress.org/changeset/5822