search

WordPress / gutenberg-starter-theme

A simple theme for testing Gutenberg.
GNU General Public License v2.0
685 stars 164 forks source link

Add embed wrappers #29

Closed pstonier closed 6 years ago

pstonier commented 6 years ago

These styles help fix the issue where embedded content falls outside of the layout.

Lines 120-135 anticipate this PR for bringing in classes for embed types(https://github.com/WordPress/gutenberg/pull/4118) and Gutenberg updating to create parity between the editor view of an embedded block vs the front-end saved view where the is a <div class="wp-block-embed__wrapper"> inside the <figure> which is a necessary piece to maintain the aspect ratio for videos.

karmatosed commented 6 years ago

There is a little conflict with recent CSS changes, could you do an iteration with those? Have you tested this against the embed blocks?

pstonier commented 6 years ago

Yes, I've tested these against embed blocks. Videos look great. Some things like Instragram and Twitter may need some additional considerations as the content does not span the full width of the area provided.

karmatosed commented 6 years ago

Awesome, thanks I merged this.