WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.36k stars 4.14k forks source link

Events Calendar Pro by Modern Tribe crashes the editor #12810

Closed pojke closed 5 years ago

pojke commented 5 years ago

Please tag as plugin compatibility.

Events Calendar Pro in version 4.5 crashes Gutenberg: image

With the following error:

TypeError: this.activateMode is not a function
    at http://nztech.me/wp-admin/load-scripts.php?c=0&load%5B%5D=hoverIntent,common,admin-bar,heartbeat,postbox,wp-util,wp-backbone,media-models,wp-plupload,wp-mediaelement,media-views&ver=5.0:11:24754
    at arrayEach (http://nztech.me/content/plugins/gravityformsgutenberg/js/blocks/core.min.js?ver=1544321579:1645:11)
    at Function.forEach (http://nztech.me/content/plugins/gravityformsgutenberg/js/blocks/core.min.js?ver=1544321579:10473:14)
    at n._createModes (http://nztech.me/wp-admin/load-scripts.php?c=0&load%5B%5D=hoverIntent,common,admin-bar,heartbeat,postbox,wp-util,wp-backbone,media-models,wp-plupload,wp-mediaelement,media-views&ver=5.0:11:24714)
    at n.initialize (http://nztech.me/wp-admin/load-scripts.php?c=0&load%5B%5D=hoverIntent,common,admin-bar,heartbeat,postbox,wp-util,wp-backbone,media-models,wp-plupload,wp-mediaelement,media-views&ver=5.0:11:24123)
    at n.initialize (http://nztech.me/wp-admin/load-scripts.php?c=0&load%5B%5D=hoverIntent,common,admin-bar,heartbeat,postbox,wp-util,wp-backbone,media-models,wp-plupload,wp-mediaelement,media-views&ver=5.0:11:25761)
    at n.initialize (http://nztech.me/wp-admin/load-scripts.php?c=0&load%5B%5D=hoverIntent,common,admin-bar,heartbeat,postbox,wp-util,wp-backbone,media-models,wp-plupload,wp-mediaelement,media-views&ver=5.0:11:28633)
    at n.e.View (http://nztech.me/wp-includes/js/backbone.min.js?ver=1.2.3:1:14744)
    at n.constructor (http://nztech.me/wp-admin/load-scripts.php?c=0&load%5B%5D=hoverIntent,common,admin-bar,heartbeat,postbox,wp-util,wp-backbone,media-models,wp-plupload,wp-mediaelement,media-views&ver=5.0:7:2616)
    at n.constructor (http://nztech.me/wp-admin/load-scripts.php?c=0&load%5B%5D=hoverIntent,common,admin-bar,heartbeat,postbox,wp-util,wp-backbone,media-models,wp-plupload,wp-mediaelement,media-views&ver=5.0:11:23570)

It seems to be issue with Lodash used in Pro version. Reported also with Modern Tribe, however, I think it should be considered in Gutenberg to load Lodash in no conflict mode.

neverything commented 5 years ago

Had the same issue, but with other blocks. It's the GravityForms Gutenberg Add-on that breaks the editor. Try turning it off for now.

swissspidy commented 5 years ago

I think it should be considered in Gutenberg to load Lodash in no conflict mode.

It actually does that already.

See https://make.wordpress.org/core/2018/12/06/javascript-packages-and-interoperability-in-5-0-and-beyond/ for reference.

pojke commented 5 years ago

@neverything you're partly right. Funnily enough I thought that it's Events Calendar because somehow with only Events Calendar Gutenberg crashes but in fact it's a combination of both So to reproduce you need Events Calendar Pro in version 4.5 and Gravity Forms Gutenberg Add-On in 1.0 RC 1.1 to crash the editor. They do work separately ¯_(ツ)_/¯

pojke commented 5 years ago

Also reverting Events Calendar Pro to version 4.4.35 fixes the problem

chrisvanpatten commented 5 years ago

Gravity Forms Gutenberg has been reported to cause a few plugin conflicts — I think Joost posted about it as well.

swissspidy commented 5 years ago

Sounds like something that should be fixed by these plugins.

I'm closing this for now, but feel free to reopen if something needs to be done in this repo.