search

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.23k stars 4.08k forks source link

Users can duplicate post titles #15282

Open karlgroves opened 5 years ago

karlgroves commented 5 years ago

Users can duplicate post titles

Issue description

It's possible for authors to create multiple posts with the same page title.

Assistive technology users may rely on the title to understand the primary purpose of each page. When titles are not unique, it may be more difficult and laborious for such users to determine what the page is about.

Remediation Guidance

Having something warn authors that another post has already been published (not drafted) with the same title would help authors ensure post titles are unique.

This need not literally prevent users from creating multiple posts with the same title, merely warn them why this is not a good idea.

Relevant standards

Note: This issue may be a duplicate with other existing accessibility-related bugs in this project. This issue comes from the Gutenberg accessibility audit, performed by Tenon and funded by WP Campus. This issue is GUT-112 in Tenon's report

afercia commented 5 years ago

An accessible warning to inform users there's already a post with the same title seems a very interesting idea. Also from an SEO perspective.

kjellr commented 5 years ago

We could theoretically open up a notification like this:

Frame

I'm not sure if it makes sense to explain why duplicate titles aren't great — bringing terms like "Accessibility" and "SEO" into the mix may further confuse things.

mapk commented 5 years ago

As mentioned in today's design triage in slack, this might be a great opportunity to use the new snackbar notifications being explored by @youknowriad right now in #15594.

Since it’s in the category of SEO, perhaps snackbar is the right amount of “intrusive”? We should probably guide and not bug people

Once that PR is merged, let's bring that pattern here. Does this work for everyone?

afercia commented 5 years ago

First time I hear about the explorations on "snackbars". While I see some accessibility considerations were reported on the related issue #13905, I'd like to ask why the issue and the PR #15594 haven't been labelled with the "Needs Accessibility Feedback" label. This appears to be a pretty important change in the UI and in the way visual/audible feedback is provided to users.

I'm a bit surprised that, while there's ongoing discussion about ways to improve collaboration between teams and improve the overall development process, the accessibility team hasn't been involved in the evaluation of this proposal before development actually started. I'd greatly appreciate some feedback. /Cc @youknowriad

mapk commented 5 years ago

@afercia let's assume positive intent. If you'll notice @youknowriad's PR doesn't have ANY labels at this point. There are no "Needs Design Feedback" labels and yet Joen somehow came across it and began to interact with it in a postive way by leaving comments. Riad is doing excellent work exploring new ideas. Let's help him out! This is what collaboration is. 😉

I'd like to note that Riad's PR is purely experimental right now. So I'll take complete blame on suggesting its possible merge which may have caused some alarm.

afercia commented 5 years ago

For the greater good of this project, I'll refrain from further comments. I'd just like to note this is more about process to improve and trust to be rebuilt.

youknowriad commented 5 years ago

haven't been labelled with the "Needs Accessibility Feedback"

That's just because it's a draft PR :) not labeled and not ready yet :)

nerrad commented 5 years ago

What about using the pre-publish checks sidebar for this for posts that aren't published yet? If this is disabled, then use notices.

Even if notices are still used, the pre-publish check might still be worthwhile for having a summary of accessibility related issues as an "are you sure" kind of thing. This additional panel in the pre-publish checks could also be a useful mechanism for teaching users about accessibility. Along with the reminders of issues existing in their content (i.e. color contrast, duplicate post title), there could be external links to why they are being notified about it. So it provides extra information that doesn't clutter up the writing process.

skorasaurus commented 4 years ago

duplicate of https://github.com/WordPress/gutenberg/issues/11241 (this has more discussion on it; so probably close the other one)