Shortcut keys conflict with browser shortcuts

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.

https://wordpress.org/gutenberg/

Other

10.32k stars 4.12k forks source link

Shortcut keys conflict with browser shortcuts #15335

Open karlgroves opened 5 years ago

karlgroves commented 5 years ago

Shortcut keys conflict with browser shortcuts

Severity: Medium
Affected Populations:
- Low-Vision
- Motor Impaired
- Cognitively Impaired
Platform(s):
- All / Universal
Components affected:
- Tools and Options

Issue description

The shortcut key provided for "Keyboard Shortcuts" is Shift+Alt+H, however this also triggers the browser "Help" dialog in Windows browsers such as Internet Explorer.

This may be confusing for users who rely on shortcut keys, since they would have to manually escape the native menu in order to reach the Keyboard Shortcuts information.

Remediation Guidance

Replace this shortcut key with something else which does not conflict with browser defaults, or allow users to change the shortcut keys.

Note: This issue may be a duplicate with other existing accessibility-related bugs in this project. This issue comes from the Gutenberg accessibility audit, performed by Tenon and funded by WP Campus. This issue is GUT-51 in Tenon's report

afercia commented 5 years ago

+1 See #3218 (October 2017), #11154, and the countless other issues related to keyboard shortcuts conflicts.

afercia commented 5 years ago

See also #15190

melchoyce commented 5 years ago

Screenshot from full report:

afercia commented 5 years ago

See also #9361 (and the screenshots attached there)

talldan commented 4 years ago

Duplicate of #9361

afercia commented 4 years ago

Since this issue is part of the WPCampus accessibility audit, can we keep it open please? It serves the purpose of keeping track of the progress on the audit. Thanks.

annezazu commented 2 years ago

@afercia since you opened https://github.com/WordPress/gutenberg/issues/9361 too that this is a duplicate of, can you decide which to keep open? It doesn't serve the project well to have two issues about the same thing and it would go a long way to have a "source of truth" for this important problem.

afercia commented 2 years ago

Closed https://github.com/WordPress/gutenberg/issues/9361 which is an older issue but I'd prefer to keep this one open as it comes from the WPCampus accessibility audit.

To summarize:

shift+alt+h on Windows opens the Firefox and Internet Explorer Help menu: the modal opens but focus is on the browser's menu. IE11 is no more relevant now, Firefox is still relevant.
On macOS, when VoiceOver is running, ctrl+option+h opens the VoiceOver help and the modal doesn't open at all.
See https://github.com/WordPress/gutenberg/issues/11154 for more conflicts.
See https://github.com/WordPress/gutenberg/issues/3218 for a proposed solution.

annezazu commented 2 years ago

Thank you for summarizing and closing <3