WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.49k stars 4.18k forks source link

Add a filter to the core-embeds others. #16951

Open markvanwijnen opened 5 years ago

markvanwijnen commented 5 years ago

Is your feature request related to a problem? Please describe. I can't find any filters in the core-embeds block, which creates the need for a lot of duplicate code for a custom embed.

Describe the solution you'd like A filter to hook into so you can easily add custom embeds.

paaljoachim commented 3 years ago

Hey @markvanwijnen

I will ping in @ntsekouras Nik here and he might have some thoughts on it.

ntsekouras commented 3 years ago

Hey 👋 - Now that embed is implemented with block variations you could just register a new block variation (registerBlockVariation). Would that be helpful?

Ref: https://developer.wordpress.org/block-editor/packages/packages-blocks/#registerBlockVariation