WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.34k stars 4.13k forks source link

Two distinct features now labeled "Tools" #19409

Closed 0aveRyan closed 1 year ago

0aveRyan commented 4 years ago

Describe the bug Originally the new header mode toggle @youknowriad added in #18624 was labeled Navigation Tools, but that heading was removed. The remaining description prominently labels them as Tools, while Tools already exists under the Main Menu for a disparate set of features.

Additionally, adding this item to the header means there are now six items users viewing the interface need to parse, which moves from the top-end of the perceptual subitizing scale into conceptual subitizing that requires additional cycles to subdivide. Depending on age and cognitive function, humans can identify up to five like items without counting, with six or more like items almost every brain must sub-divide items into smaller groups to compute the whole.

Expected behavior At minimum the confusing double-use of Tools should be addressed. This could be as simple as relabeling or adjusting the descriptive text.

A few ideas...

Screenshots Screen Shot 2020-01-05 at 12 34 30 AM Screen Shot 2020-01-05 at 12 34 43 AM

jasmussen commented 4 years ago

Thanks for the ticket! I would definitely agree we need to try and reduce the amount of tools up there, and to combine and simplify where possible.

It's a larger effort, and the reason it exists as it is today is because the ability to easily select the layers of a block with complex nesting, is an important issue to solve, and the selection tools (perhaps that's what they should be called?) are key to making that easier. Specifically, with the default edit tool, you click any text field to edit it directly. With the select tool, you click any block to select the block. Just like in Figma or Photoshop or other desktop apps so to speak.

In #18667 there are efforts underway to simplify the general block editor UI. Based on that work you can see in https://github.com/WordPress/gutenberg/pull/19082#issuecomment-567508590 a screenshot that removes the document outline from the top toolbar, and puts in in the bottom right corner under a word count. Another option ticketed in #4287 is to make the document outline live in the ellipsis menu on the right.

mapk commented 4 years ago

It's good to note that "Manage All Reusable Blocks" will be going away from this section with https://github.com/WordPress/gutenberg/pull/19400#issuecomment-570742294.

We can also move the "Welcome Guide" under the Options modal dialog in the "General" section. I think it works well in relation to the "Inserter help panel" there.

Screen Shot 2020-01-06 at 12 24 07 PM

This would leave the Menu Group looking like this:

Sidebar Menu

I wonder if these items are independent enough that they can exist on their own like "Options" does? And then we can just drop the section title. So it would look like this:

Sidebar Menu-2

0aveRyan commented 4 years ago

@jasmussen I love the selection toggle, I totally get why it's needed -- this ticket is definitely more about the labels than the functionality itself. I personally prefer the approach in #19082 over tucking the outline behind an additional click in the Menu in #4287, or having the approach in #19082 act as a trigger for the tucked approach in #4287.

Right now, there are three significant ways to modify the editor experience that are all loosely-related in nomenclature (at least in English).

There's choosing an Editor [Visual/Code], choosing View [Top Toolbar/Spotlight Mode/Fullscreen Mode] (which can be combined despite the singular View) and now choosing (Navigation) Tool [Edit/Select].

While I like the simplicity and parallelism of having View, Editor (Plugins) and Tools under the Editor Main Menu, View used in the singular somewhat suggests only one can be active at a time. I'm not proposing this as a new name, but really these are different experiences... visual options/modifiers/configuration for how the editor displays. I'm not crazy about View alone (or Mode) for a top-level label for these, but I'm struggling to find another one-word label to really address what they do.

While it's beyond the scope of the main issue of having two features labeled Tools, part of the confusion stems from all of these semi-related labels getting applied across the UI.

To me, Mode for Edit/Select makes more sense than Tools, which better applies to features that perform an action like it's used in the menu for copying content, showing keyboard shortcuts, etc. Mode would also be an interesting place for features like Annotation/Approval/Per-Block Revisions, etc, so perhaps making it a binary toggle like Editor doesn't make sense.

So if Mode was dropped from Spotlight + Fullscreen view labels that would simultaneously make Top Toolbar (or Unified) feel less bespoke from the other two view labels and free up the Mode keyword to be used for Edit/Select.

Then... Editor - Would remain locked as the Visual/Code Binary View - Would loose Mode and remain locked to Core tools Mode - Would be a good place to allow 3rd party extension

jasmussen commented 4 years ago

Great thoughts here, and a lot to parse.

For starters, I think it's worth for now shelving the conversation around Top Toolbar/Spotlight/Fullscreen Mode, as I suspect those could morph or move or change in entirely separate conversations. For example, I could see spotlight mode potentially going away entirely, made less necessary by work in #18667. Fullscreen mode I personally would love to see default and non-optional, but there's a larger wp-admin discussion to be had here.

The visual/code editor choice also feels like separate to me, as the two can't necessarily coexist as equals. I.e. you can make changes in the code editor that will break/not work when switching back to the visual editor, whereas the items currently in the tools menu do not affect features available.

Finally it's worth noting that #17949 is exploring potentially adding a 3rd tool to the tools/mode/edit dropdown, which would invoke a commenting mode where selecting a block allows you to attach comments/notes to that block, which can then be addressed, just like Word or Google Docs.

All that is preface for the challenge, which I agree, better nomenclature helps a lot here.


In discussing the best nomenclature it's worth looking again at what the dropdown, currently labelled "Tools", hopes to accomplish.

Primarily, it serves to provide a visual indicator and click affordance for the tool you have selected. While this is technically a mode — i.e. when you have the Edit tool selected you can click text etc. etc. — it is no different from how Figma attaches modes to tools.

figma

Let's imagine you had a 3rd tool there, for attaching comments or editorial notes to blocks, like say you're reviewing a post from a colleague before it's going live. You'd have three tools there:

Each of those has a mode attached, but the mode is secondary to the functionality the tool offers. This is why I'm personally more of a fan of calling these "tools", as they describe an interaction, rather than "modes", which I feel is a little on the technical side.

This is also why I feel the three tools could belong together in a dropdown like this — you would flow in and out of each tool as you are editing, layouting, and annotating a document. This is in contrast to Fullscreen/Spotlight which is "set and forget", and to the code editor, which is also either a set it and forget it preference, OR a place you go when you need to see what's wrong under the hood.


In that light, how would these labels sound?

Is this better?

0aveRyan commented 4 years ago

@jasmussen circling back to this...

I'll try to keep a few finite thoughts here:

jasmussen commented 4 years ago

I don't think Fullscreen mode excludes the continued need for Spotlight mode -- it should stay!

I'm sort of coming around to that too — though in a different way. I don't personally find it useful at all for editing posts, however there are situations where it might be useful, like when editing a reusable block, the act of doing so might put a spotlight on just that block. Or when editing template parts.

It seems like the next steps here might be to actually take the controls in the top toolbar which is stabilizing, and then plot out a table with verbiage suggestions, and then move to PR. Does that sound about right?

0aveRyan commented 4 years ago

@jasmussen Sounds good, though we can keep hammering away at #19447, which will probably help inform whatever happens here.

jordesign commented 1 year ago

Looping back to this issue - I do note that we still have 'Tools' in 2 areas, but am wondering if other advancements have made this less of an issue? What do you think @0aveRyan @jasmussen ?

jasmussen commented 1 year ago

I tend to think we can close this one and reopen if the concern resurfaces, so much has changed since this one that there's new context which may reframe details here.