WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.56k stars 4.22k forks source link

New G2 icons #21995

Closed Garance91540 closed 2 months ago

Garance91540 commented 4 years ago

I've been working with @jameskoster and @jasmussen to create new G2 icons. (I'm currently working on the Woo app and noticed there were no current G2 icons equivalent for some existing icons).

Screen Shot 2020-04-30 at 2 54 00 PM

svg files here G2-icons.zip

First time contributing to this project so don't hesitate if you need other formats.

cc @pablohoneyhoney

Soean commented 4 years ago

@Garance91540 Looks good ๐Ÿ‘, but I can't access the google drive link.

pablohoneyhoney commented 4 years ago

Looking good!

It would be useful to see them in context as well as in the grid system to understand balances.

Shapes, could you explain its function? Seems a bit busy, and has a bit of tension between triangle and square.

Garance91540 commented 4 years ago

@Garance91540 Looks good ๐Ÿ‘, but I can't access the google drive link.

@Soean I added a zip file with the icons in the description

Garance91540 commented 4 years ago

@pablohoneyhoney here are the icons with more context:

in grid system:

Screen Shot 2020-04-30 at 5 59 03 PM

in context of the Product screen of the Woo app. (The shapes icon will be used for product variations such as color or material):

Screen Shot 2020-04-30 at 6 16 46 PM

I'll work on a new iteration for the shapes icon!

Garance91540 commented 4 years ago

Hi @pablohoneyhoney ,

Here are some new options for the "shapes" icon. Curious to hear your thoughts!

Screen Shot 2020-05-04 at 1 40 49 PM
jameskoster commented 4 years ago

I wonder if something more universal could work for the variations use case... something like 'copy' or 'swatches'? ๐Ÿค”

Garance91540 commented 4 years ago

I wonder if something more universal could work for the variations use case... something like 'copy' or 'swatches'?

@jameskoster I can't unsee "copy" when I see those :)

What about something like this?

Screen Shot 2020-05-11 at 6 48 39 PM
jameskoster commented 4 years ago

The vertical space between the triangle and the shapes below doesn't seem consistent with the horizontal space between the squircle and the circle. Otherwise that looks pretty good to me!

Garance91540 commented 4 years ago

The vertical space between the triangle and the shapes below doesn't seem consistent with the horizontal space between the squircle and the circle.

Screen Shot 2020-05-11 at 7 19 13 PM

updated ^

In that case it seems like we have this whole set of new icons finalized! ๐ŸŽ‰๐ŸŽ‰๐ŸŽ‰

G2 icons.zip

Garance91540 commented 4 years ago

@pablohoneyhoney , did you still have feedback on these icons or are we good to go?

pablohoneyhoney commented 4 years ago

Thereโ€™s something obscure about the different shapes together. My eye tries the decipher a few things at the same time and I donโ€™t necessarily associate the 3 shapes with variations (color, materials). If itโ€™s simply to convey variants, have you tried to only use four circles that transmit choices? @Garance91540

jameskoster commented 4 years ago

I think that could work, as long as the circles are different some how.

But if all the objects have to be alike then we'd need to work out a way to illustrate the relationship between them. That being the concept of a common source with different variants. Maybe something like a "node" icon:

Garance91540 commented 4 years ago

If we think an icon composed of similar elements will work better, then I think we could use the existing "product-categories" icon I'm seeing in the G2 design Figma file instead of creating this new "shapes" icon:

Screen Shot 2020-05-26 at 3 13 49 PM
pablohoneyhoney commented 4 years ago

I think that works

investmentgroupVenture commented 4 years ago

Hi

carolinan commented 3 years ago

Removing the good first issue label because it is not clear what needs to be done here.

annezazu commented 2 months ago

Closing this out as, four years on, it's not clear what, if anything, is actionable still.