search

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.32k stars 4.12k forks source link

Block Editor: LinkControl: Migrate suggestions rendering to URLInput #22439

Open aduth opened 4 years ago

aduth commented 4 years ago

Previously: https://github.com/WordPress/gutenberg/issues/18061#issuecomment-580480464

As discussed in #18061, the new LinkControl component can be considered as a composite component of URLInput, plus labeling behaviors associated with similar *Control input control components. In this model, URLInput should be considered a very barebones component whose sole responsibility should be to render an input field and associated URL autocompletion results from which to pick a value.

Currently, URLInput is enhanced to support "custom" rendering behavior of suggestions, which is leveraged by LinkControl to customize the appearance of its suggestions. These should be migrated to URLInput and considered to be the new default appearance of URL suggestions. The motivation for this is to assure consistency of link suggestions for all use of URLInput (UX), and avoid the maintenance cost associated with maintaining multiple implementations of search result appearances (DevX).

paaljoachim commented 4 years ago

This issue might be associated: https://github.com/WordPress/gutenberg/issues/17293

In regards to: "Make link selection consistent"