Text link color doesn't change for Tag Cloud Block

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.

https://wordpress.org/gutenberg/

Other

10.49k stars 4.18k forks source link

Text link color doesn't change for Tag Cloud Block #24568

Closed khushbudesai1983 closed 3 years ago

khushbudesai1983 commented 4 years ago

Describe the bug A clear and concise description of what the bug is.

To reproduce

Add Tag Cloud Block
Transform block into a group.
From Block settings on the right side, change text link colour.

The text link colour in the tag cloud block won't change. Expected behaviour A text link colour should be changed as per the selected text colour of the block settings.

Screenshots

Transform to group wp5 5 new #fcfbe1 bug

Editor version (please complete the following information):

WordPress version: 5.5

Desktop (please complete the following information):

OS: [Windows 10]
Browser chrome

annezazu commented 4 years ago

Thanks for reporting this @khushbudesai1983! I replicated this with WordPress 5.5 & Gutenberg 8.7.1.

kishanjasani commented 4 years ago

@kirilzh Sorry I didn't see you have assigned yourself to it. I have added a PR for this issue please have a look. Thanks

kirilzh commented 4 years ago

@kishanjasani no worries. I was struggling myself to figure out what was the problem. Glad to see you handled it with CSS 🎉

kishanjasani commented 4 years ago

Thanks @kirilzh :slightly_smiling_face:

youknowriad commented 3 years ago

Hey there! thanks for the issue.

But unless I'm missing something, this doesn't really make sense to me. These are links not text so they should get the link color (like they do now) and the text color shouldn't override them.