search

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.52k stars 4.21k forks source link

Package `@wordpress/edit-post` assumes it will be installed at the same level than `@wordpress/interface`. #26343

Open scinos opened 4 years ago

scinos commented 4 years ago

Describe the bug Package @wordpress/edit-post assumes it will be installed at the same level than @wordpress/interface.

This is the problematic line https://github.com/WordPress/gutenberg/blob/master/packages/edit-post/src/style.scss#L1

When the structure is

myApp
    - node_modules
        - @wordpress/edit-post
        - @wordpress/interface

Everything works as expected. However, this structure is also valid, specially in a monorepo (for example, if there are multiple versions of @wordpress/edit-post):

myApp
    - package
        - node_modules
            - @wordpress/edit-post
    - node_modules
        - @wordpress/interface

In that case, the path "../../interface/src/style.scss"; won't resolve to anything.

kathrynwp commented 2 years ago

@scinos Hi! I see there's a PR that looks like it was merged a while back. Can this issue be closed now? Thanks for taking a look.

kathrynwp commented 2 years ago

And if that PR is not related, if you wouldn't mind confirming whether the original issue is still valid, that would be super helpful. Thanks!