WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.55k stars 4.22k forks source link

Overview: Inline image improvements #28813

Open paaljoachim opened 3 years ago

paaljoachim commented 3 years ago

What problem does this address?

EDITING this issue to focus on various Inline image issues.

It is very limited in how we can control the Inline Image. Here is an example of what it currently looks like.

Screen Shot 2021-02-07 at 14 23 58

What is your proposed solution?

As @melchoyce mentioned in this comment: https://github.com/WordPress/gutenberg/issues/19426#issuecomment-771757981 "It might make more sense to refactor inline images to be child blocks, so they can have their own toolbar for settings. That would help eliminate this one-off UI and make the block's behavior more consistent." Based on Mathias comment below. We need to instead create a custom UI for the inline image feature.

Overview of Inline Image issues:

An example would be to control the height as mentioned in this issue. https://github.com/WordPress/gutenberg/issues/18035

Improve inline image sizing https://github.com/WordPress/gutenberg/issues/19426

Inline Images: Can't replace image https://github.com/WordPress/gutenberg/issues/25909

Inline images shows as Unattached in the media library https://github.com/WordPress/gutenberg/issues/17658

Inline linked image: inline popovers overlap and can hardly be used https://github.com/WordPress/gutenberg/issues/15761

Inline Images no longer show handles when selected https://github.com/WordPress/gutenberg/issues/15083

Inline images can't be resized using only the keyboard https://github.com/WordPress/gutenberg/issues/10595

How to create a custom inline-block? https://github.com/WordPress/gutenberg/issues/10235

It was brought up during a design triage on Slack: https://wordpress.slack.com/archives/C02S78ZAL/p1612282641102200

mtias commented 3 years ago

It's not possible to use child blocks for inline images. Blocks are block elements, not inline formatting. Improvements to inline images UI should be proposed separately and need custom UI.

paaljoachim commented 3 years ago

I can edit this issue to become an inline image tracking issue instead. Then I will look at creating a custom UI issue for the inline images.

mtias commented 3 years ago

Yes, the width in particular is quite confusing.

XVII commented 1 year ago

An additional item for your inline image megathread: #48150

westonruter commented 1 year ago

Another inline image issue, this time from Trac: Core-59352 "Inline images inserted in the block editor can erroneously get fetchpriority=high". Also mentioned there is the incorrect width and height are added by wp_img_tag_add_width_and_height_attr(), resulting in wp_img_tag_add_srcset_and_sizes_attr() adding the wrong sizes which finally results in an oversized image being served.

mrwweb commented 4 months ago

63323: "No ability to edit inline image alt text in context"