Open fluiddot opened 3 years ago
This one can be simply fixed by
diff --git a/package.json b/package.json
index 3c75522414..f3c07a917c 100644
--- a/package.json
+++ b/package.json
@@ -16,7 +16,7 @@
},
"engines": {
"node": ">=10.0.0",
- "npm": ">=6.9.0 <7"
+ "npm": ">=6.9.0"
},
"config": {
"GUTENBERG_PHASE": 2,
or, if we prefer,
diff --git a/package.json b/package.json
index 3c75522414..dcbe81d1c2 100644
--- a/package.json
+++ b/package.json
@@ -16,7 +16,7 @@
},
"engines": {
"node": ">=10.0.0",
- "npm": ">=6.9.0 <7"
+ "npm": ">=7.6.0"
},
"config": {
"GUTENBERG_PHASE": 2,
, right?
It's just that we can't do that yet because of #29524 and #29527, right?
Yeah, this could be easily fixed just by changing the npm engine value as you commented.
The only thing to keep in mind is that we would need to merge this change into trunk
branch first so the PR checks of "Update lock file format version to version 2 (NPM 7)" PR pass.
Engines update would be nice.
Currently can't install dependencies on Apple Silicon machines because of this restriction.
Description
When using npm version
7.6.0
in the workflowsCompressed Size / Check (pull_request)
andPerformances Tests / Run performance tests (pull_request)
, we checkouttrunk
but due to the recent changes limiting the version of npm to v6, the processes fails.Step-by-step reproduction instructions
<7
condition from the npm engine section ofpackage.json
file (example)npm install
Add the following code to a GitHub actions workflow that uses
trunk
branch (likeCompressed Size
):The code has to be placed after the checkout and npm cache restore, here is an example.
Expected behaviour
GitHub actions workflows that use
trunk
branch should succeed.Actual behaviour
GitHub actions workflows that use
trunk
branch fail.Screenshots or screen recording (optional)
N/A
Code snippet (optional)
WordPress information
Device information