WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.39k stars 4.15k forks source link

Search Block: Change Button Position Does Not Show Indication of What is Selected #30746

Closed deborah86 closed 3 years ago

deborah86 commented 3 years ago

Description

The change button position on the search block doesn't show any indication of what option is selected.

Step-by-step reproduction instructions

  1. Add a search block to the editor
  2. Select either no button, button inside, or button outside,

Expected behaviour

The icon of the selected option to have a dark background to indicate that it has been selected.

Actual behaviour

The backgrounds don't change for any of the options selected.

Screenshots or screen recording (optional)

https://1drv.ms/u/s!Agz9k3UFAizZig5eE0CWwaq9bdYR?e=4mNAZ3 image

Code snippet (optional)

WordPress information

Device information

priethor commented 3 years ago

Thanks for reporting @deborah86 ! I can reproduce this issue with Gutenberg 10.4-RC1 as well.

javierarce commented 3 years ago

Also, shouldn't the icons be aligned to the left?

javierarce commented 3 years ago

I found this issue is pretty similar to this older one: Search Block: Button options needs indicator which option is active. #27330.

@karmatosed's solution here, makes sense to me… so maybe we should close this issue?

priethor commented 3 years ago

I agree @javierarce, let's close it as duplicate.