search

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.54k stars 4.22k forks source link

Add Preferences modal to the Widgets screen #32711

Open critterverse opened 3 years ago

critterverse commented 3 years ago

Opening this issue based on feedback in https://github.com/WordPress/gutenberg/pull/32569#issuecomment-860480681.

When we first introduced the ellipses menu into the Widget editors, only one Preference was available (compared to 10+ available in the post editor), so it was introduced as an inline option within the ellipses menu. Now that we are starting to adding more Preferences, we should look at introducing the Preferences modal.

One consideration is that there are only two Preferences available currently, which would reduce the submenu down to two pages with one item on each. But I think the UI holds up and will likely get more filled in over time:

Preferences modal showing the "General" tab with one option Preferences modal showing the "Blocks" tab with one option

Since there's currently only one Preference available to the Customize Widgets screen, I would lean towards leaving that as an inline option in the ellipses menu until at least one more option is added.

talldan commented 3 years ago

Relevant to this is https://github.com/WordPress/gutenberg/issues/31965. We could do with a bit of a refactor of editor preferences, as they're all implemented as part of the post editor.

I have started work on this, but I'm not prioritising it until 5.8 is shipped.