Ultimately, inconsistent visual rhythm of a site's design.
Gap is the vertical/horizontal rhythm of content, of which is also relevant as the gap between these blocks that support background color, and the content within them. So instead of using arbitrary values for this padding, let's consider using the blockGap value to also define the padding in these blocks.
What is your proposed solution?
Instead of using $block-bg-padding--v and $block-bg-padding--h, which are 1.25em and 2.375em respectively, perhaps we use the following:
This would result in using the exact same values as today, for themes that do not support theme.json (or that have opted out of supporting blockGap) while allowing themes that do leverage blockGap to have more appropriate spacing rhythm throughout the site's design language.
Screenshots:
.has-background padding adapting, based on a smaller blockGap setting:
.has-background padding adapting, based on a larger blockGap setting:
scruffian
commented
2 years ago
What problem does this address?
Ultimately, inconsistent visual rhythm of a site's design.
Gap is the vertical/horizontal rhythm of content, of which is also relevant as the gap between these blocks that support background color, and the content within them. So instead of using arbitrary values for this padding, let's consider using the blockGap value to also define the padding in these blocks.
What is your proposed solution?
Instead of using
$block-bg-padding--vand$block-bg-padding--h, which are1.25emand2.375emrespectively, perhaps we use the following:This would result in using the exact same values as today, for themes that do not support theme.json (or that have opted out of supporting
blockGap) while allowing themes that do leverageblockGapto have more appropriate spacing rhythm throughout the site's design language.Screenshots:
.has-backgroundpadding adapting, based on a smaller blockGap setting:.has-backgroundpadding adapting, based on a larger blockGap setting:Just tossing some ideas out. :)