search

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.36k stars 4.13k forks source link

Navigation Block: Overlay menu options consistency #38045

Open pedro-mendonca opened 2 years ago

pedro-mendonca commented 2 years ago

Inconsistency in Overlay Menu settings

Currently the options are:

Off | Mobile | Always imagem

Improved consistency

Suggested options are:

Never | Mobile | Always

imagem

jasmussen commented 2 years ago

Thanks for the ticket! We actually had the term "Never" used in earlier mockups and PRs, but changed it to "Off" based on feedback and confusion. I lean towards "Off", because the entire overlay menu is literally disabled when that option is chosen, and I'd like for the contents of the overlay menu to be customized separately some day in the future, meaning it could be an entire separate screen. But it's not a strong opinion, and I'd be happy to make a PR to change the label. Just important we get some agreement first, lest we go back and forth on this one.

jordesign commented 1 year ago

Hey @pedro-mendonca - just looping back to this issue - did you have a plan to open a PR for this issue so it can be discussed?

pedro-mendonca commented 1 year ago

Hi, I've highlighted what seemed an inconsistency, but looks like it was a decision. Also, seems that there should be a discussion that never occurred. I'll be happy to open a PR if the decision is to change.