search

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.36k stars 4.13k forks source link

[WP 6.1] Fluid and spacing settings in theme.json are lost when theme export #44546

Closed mayuge3 closed 1 year ago

mayuge3 commented 1 year ago

Description

When I use theme export,

Step-by-step reproduction instructions

  1. Use WP 6.1 nightly and Twenty Twenty Three without gutenberg plugin
  2. Go to the site editor.
  3. Select Three dots menu > Export

Screenshots, screen recording, code snippet

spacing before export: n1631

spacing after export: n1632

fluid before export: n1633

fluid after export: n1634

Environment info

WP 6.1 (latest nightly via Beta Tester plugin), instawp install TT3 included in WP 6.1 nightly. Gutenberg plugin deactivated

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

glendaviesnz commented 1 year ago

I have a fix for the spacingScale value here, still trying to work out the fluid font value as it isn't related and only happens in 6.1, not GB trunk

glendaviesnz commented 1 year ago

The fluid flag was a different issue and a potential fix for it is here

ramonjd commented 1 year ago

Thank you @mayuge3 Also reported in https://core.trac.wordpress.org/ticket/56684 Props to you!

mayuge3 commented 1 year ago

Thank you!

I'm not familiar with technical details, so I opened another issue #214 at TT3, is it related to this issue's fluid problem...?

dream-encode commented 1 year ago

I was looking to merge this, but I want to make sure this comment by @tellthemachines is addressed in the final PR:
https://github.com/WordPress/gutenberg/pull/44555#pullrequestreview-1124645012

glendaviesnz commented 1 year ago

but I want to make sure this comment by @tellthemachines is addressed in the final PR

thanks @dream-encode, I will look at the issue with casting to ints on a separate PR as it will be a bit trickier to resolve and test.

ndiego commented 1 year ago

@glendaviesnz I just wanted to confirm that this issue is all set, given the merged and closed PRs. I noticed the issue still had the Backport label, so I wanted to double check before I removed it. Thanks!

glendaviesnz commented 1 year ago

Thanks @ndiego, have removed the label now.