WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.57k stars 4.22k forks source link

Remove the "Extended Settings" wrapper #4545

Closed johnbillion closed 6 years ago

johnbillion commented 6 years ago

Issue Overview

The "Extended Settings" panel appears in the sidebar if any custom sidebar meta boxes are registered. This is an expandable wrapper panel for the custom sidebar meta boxes.

I think we should consider removing this wrapper panel and display the custom meta boxes in the same way that each of the default sidebar panels are displayed. This means that custom meta box panels remain just as discoverable as the default panels.

Expected Behavior

On a site with a custom sidebar meta box, I'd expect the meta box to appear in the same way that the built-in meta box panels do.

Current Behavior

The custom sidebar meta box is unnecessarily hidden behind the "Extended Settings" toggle.

Possible Solution

Display custom sidebar meta boxes in the same way that built-in meta box panels are displayed.

StaggerLeee commented 6 years ago

What is this block doing anyway ? I have some metaboxes from plugins and clicking on "Extended Settings" header does nothing.

hedgefield commented 6 years ago

I agree, it's an extra click that's not necessary, the metaboxes contained within are already styled to match Gutenberg.

@StaggerLeee it contains metaboxes that were located in the side column in the classic editor (such as the yoast internal linking metabox). If a plugin only had a wide metabox, that appears below the editor yeah.

StaggerLeee commented 6 years ago

Don´t know if I found a bug or. It is empty (2 instalaltions) unless i disable/enable all plugins. on second installation switch to default theme/come back to custom one. Then all Metaboxes appear in righ sidebar. Those what should appear anyway.

https://github.com/WordPress/gutenberg/issues/4887

hedgefield commented 6 years ago

Might also solve #5177.

karmatosed commented 6 years ago

If I am right you are suggesting moving the metaboxes from below content to the sidebar? If I am correct in that then I wouldn't suggest that from a design point of view. It is a smaller area and confuses content types. Also some of the rich metaboxes could get really confusing. I am checking that is what is being suggested though. Let me know if not.

johnbillion commented 6 years ago

Nope, nothing to do with the meta boxes that appear below the main content. It's just wrapper of the Extended Settings in the sidebar that should be removed, so any meta boxes that are contained within it appear in the same manner as all the other meta boxes in the sidebar.

karmatosed commented 6 years ago

Thanks for clarifying, I was a little confused on where we were going :)

illyaking commented 6 years ago

I use the Extended settings for WP Multisite Crosspost. The dialogue box to type in boxes are extremely narrow and almost unusable. I have to switch back to classic editor to cross post, which messes up my post :( Here is what I see... extendedsettings01

spwarner commented 6 years ago

As a plugin author who uses side metaboxes, I'd like to see this change implemented. The extra "Extended Settings" panel is just a bother!

claytoncollie commented 6 years ago

Please remove the wrapper

karmatosed commented 6 years ago

I think in context this is fair to do. Let's remove the design feedback and get this moved to a PR.

leahkoerper commented 6 years ago

I'm stoked to see this moved into the 5.0 milestone! Thank you!

danielbachhuber commented 6 years ago

I'm stoked to see this moved into the 5.0 milestone! Thank you!

To clarify, I initially added to the WordPress 5.0 milestone to make sure the issue was addressed prior to 5.0, not as affirmation of the suggested change.