search

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.34k stars 4.13k forks source link

No way to close Link UI unless in "edit" mode #47544

Open getdave opened 1 year ago

getdave commented 1 year ago

Currently the "Cancel" button is only displayed when you are in editing mode. This will close the UI. However if you are simply previewing the link (and not editing) there is no means of closing the UI other than clicking away.

I believe it is this which causes problems for users of assistive tech. Seems related to https://github.com/WordPress/gutenberg/pull/47327.

When editing a link, there's no 'cancel' option unless you're currently editing; the preview state of a link isn't cancellable. If a keyboard user tabs into the link control panel, they aren't offered a clear way to exit.

Originally posted by @joedolson in https://github.com/WordPress/gutenberg/issues/47310#issuecomment-1399557772

richtabor commented 1 year ago

they aren't offered a clear way to exit.

Is esc not clear/standard?

joedolson commented 1 year ago

esc is standard, but requires prior knowledge to be aware that it's available. Particularly for users with cognitive impairments, having a clearly labeled control to exit is important. Giving users a perceivable exit path supports users who don't know the invisible exits (clicking outside of the UI or Esc).

getdave commented 1 year ago

@richtabor I think we should review the designs in https://github.com/WordPress/gutenberg/issues/50891 with the a11y team and see if there's anything that has been missed.

I would recommend that we do the ground work to come up with a list of potential a11y concerns and ask them for their feedback on these. If there is any additional feedback we can also look into that.

Happy to help with this.

richtabor commented 1 year ago

@richtabor I think we should review the designs in https://github.com/WordPress/gutenberg/issues/50891 with the a11y team and see if there's anything that has been missed.

Just closing the loop that we've conducted the review per https://github.com/WordPress/gutenberg/issues/50950