WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.48k stars 4.18k forks source link

Browse Mode: Consider adding animation to canvas on hover to highlight that it's editable by clicking #47656

Closed annezazu closed 1 year ago

annezazu commented 1 year ago

What problem does this address?

Similar to this https://github.com/WordPress/gutenberg/issues/47583 and this https://github.com/WordPress/gutenberg/issues/47410, I am still hearing feedback from across the community that folks are confused by how to edit the templates and template parts. This was discussed at length in this prior discussion issue for design https://github.com/WordPress/gutenberg/discussions/45346

What is your proposed solution?

At this point, I think we need to consider one of the following for 6.2, depending on where https://github.com/WordPress/gutenberg/issues/36667 lands:

Either way, the current experience remains a touch confusing and a shift in thinking that we should expect and plan for. @youknowriad and @WordPress/gutenberg-design

Mamaduka commented 1 year ago

Clicking the canvas now will switch to the edit mode. See #47676.

ndiego commented 1 year ago

@Mamaduka beat me to it. Yeah, clicking on the canvas allows you to edit the template now.

site-editor-editing-flow

paaljoachim commented 1 year ago

In addition... What about double clicking the currently selected template to have it open in Edit mode? Similar to double clicking a document on the Mac.

jameskoster commented 1 year ago

Having the frame act as a big Edit button helps, but we need to add some kind of hover effect to indicate the interactivity. One idea would be to slightly scale the frame upwards which hints at the resultant behavior on click:

https://user-images.githubusercontent.com/846565/217841877-51b18035-40cf-42db-9e68-dc2bd5e48aac.mp4

apeatling commented 1 year ago

Since this is in todo now, is it agreed that the scale on hover that @jameskoster posted above is the way to go? It seems good to me.

jameskoster commented 1 year ago

If we can make the animation smooth then I think it's a good place to start.

richtabor commented 1 year ago

Having the frame act as a big Edit button helps

I don't think we need a pointer for "Edit" as it's the secondary entry point — now that you can click on the frame to open it.

annezazu commented 1 year ago

Agreed. At the same time, is there a way to add some light animation to indicate as much as shown above? I'll retitle this issue for now.

glendaviesnz commented 1 year ago

Have started work on this here, but I haven't used framer motion before, so I may be a bit slow as I learn it in the process - so feel free to jump in with your own fix if you are more familiar with this lib.