WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.49k stars 4.18k forks source link

Ability to add a favicon even if there is no site logo #50860

Closed andxblink closed 5 days ago

andxblink commented 1 year ago

Ability missing to add a favicon if there is no "image site logo", but only a "text site logo". Currently, this results in the WordPress default favicon, which my not be preferred.

hanneslsm commented 1 year ago

You can add a favicon, without having a site logo. For that, use the customizer by following this link on you website /wp-admin/customize.php?autofocus[section]=title_tagline

However, I can confirm that currently this link can only found on the site logo block settings, which is not ideal.

image
andxblink commented 1 year ago

Current solution:

  1. Use the site-logo-block to open customizer
  2. add the favicon in customizer
  3. delete the site-logo-block
paaljoachim commented 1 year ago

Thank you for this issue! This is really important missing feature that still has not been added that I know about. @WordPress/gutenberg-design

jordesign commented 1 year ago

Could we have a setting added under Settings > General for this? And if there is an image already selected - the 'Use as Site Icon' option (in the Site Icon block) defaults to on?

paaljoachim commented 1 year ago

Hey @jordesign I found this WordPress Trac ticket: Add an option to configure the site icon in general settings https://core.trac.wordpress.org/ticket/54370

jasmussen commented 1 year ago

I can't find the issue at the moment, but I think I suggested a Site editor > Settings section for the future, to hold things like these, in an issue about where to store global settings that I vaguely recall @andrewserong creating.

paaljoachim commented 1 year ago

That sounds like a very good idea Joen! Thank you for sharing!

jameskoster commented 1 year ago

@jasmussen I think that was this issue, which was morphed to narrow scope, and didn't include the site icon setting.

I think we should open a new issue for global settings, or repurpose this one.

jasmussen commented 1 year ago

Ah yes, perfect! This was the comment I made.

Marc-pi commented 11 months ago

yep, if we want to quit /suppress the old customizer because of the new paradigm (FSE), we neeed indeed a new setting option within the editor maybe it will be proposed through the new admin works (phase 3) ?

MaggieCabrera commented 9 months ago

There's a valid use case where you don't want your site logo to look like your favicon and vice-versa. You might want them to have different aspect ratios for one

andrewserong commented 8 months ago

Just bringing over a bit of the discussion from #59298. In WP 6.5, the settings page of wp-admin will have an area for adding a site icon (trac ticket: https://core.trac.wordpress.org/ticket/54370). One of the ideas in #59298 was whether it would also be helpful for the site editor to have a dedicated place for updating the site icon so that folks don't need to navigate out of the site editor in order to make updates? This is probably less urgent now that we'll be able to link users to the settings page instead of into the customizer (the issue to update the link is here: https://github.com/WordPress/gutenberg/issues/59382).

I'd be curious to hear what folks think, if the new area in the settings page for updating the icon is enough for now.

jameskoster commented 8 months ago

I'd agree it's less urgent now. I'd be tempted to hold off adding the setting to the site editor until we have a slightly clearer overall picture of the ongoing Admin design work.

Sam-Xronn commented 3 months ago

@andxblink I feel like this issue can be closed now? The WP 6.5 feature has covered off this issue?

richtabor commented 3 months ago

Makes sense to me.

wdburgdorf commented 6 days ago

How is this covered? I still see no option to set the favicon. Settings ("Style Book") only has the site logo, no favicon. (WP 6.6.2)

hanneslsm commented 5 days ago

How is this covered? I still see no option to set the favicon. Settings ("Style Book") only has the site logo, no favicon. (WP 6.6.2)

You can now change the favicon / site icon in the general settings. https://core.trac.wordpress.org/ticket/54370 I guess this resolves this issue and can be closed.

jasmussen commented 5 days ago

Thanks for responding that. Closing as fixed.