search

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.51k stars 4.2k forks source link

Tracking issue: Image Lightbox #51132

Open artemiomorales opened 1 year ago

artemiomorales commented 1 year ago

This tracking issue is for identifying bugs and features related to the experimental lightbox, introduced in #50373.

MVP

v0.1

Goal: Provide a robust, stable implementation supporting all single image features with UI exposed publicly to users for WordPress 6.4 Target Deadline: 17 October 2023

WordPress 6.5 Maintenance

Potentially for WordPress 6.6

v0.2

Backlog

gziolo commented 1 year ago

Sharing more issues, I reported today:

ajlende commented 1 year ago

Added one more that I found

michalczaplinski commented 1 year ago

I've opened the PR to:

cbravobernal commented 1 year ago

I've updated the issue description with these new PRs

artemiomorales commented 1 year ago

I've updated the issue description with these new PRs

@c4rl0sbr4v0 Great, thanks! Heads up that I moved #52765 to Interactivity Behaviors MVP instead, since this issue is more a catch-all for all tasks related to the lightbox specifically, though am happy to discuss and iterate if there's a better approach.

artemiomorales commented 1 year ago

Changes in Scope for v0.1

We've added a few issues to the v0.1 release, with a new target deadline of 25 August 2023. You can find more details in the dedicated Interactivity API Behaviors MVP tracking issue.

New Scope for v0.2

Planning for WordPress 6.4 has also kicked off, and I've begun outlining plans for a v0.2 inclusion of the lightbox.

I've set the target goal to be the following: Provide a robust, stable implementation supporting all single image features in WordPress 6.4.

We'll need to perform discovery around some proposed additions to the scope, including the tasks to be done for adding lightbox support for the cover block, featured image, and potentially other blocks.

As of now, that deadline has been set for 22 September 2023, the last Gutenberg release before the 6.4 beta.

That timeline and feature set as proposed by design honestly seems a bit tight at the moment. That being said, I'm happy to hear thoughts and further discuss the items for inclusion in 6.4 and this update overall. Thanks!

artemiomorales commented 1 year ago

Biweekly Update

The lightbox was originally envisioned as an MVP of an idea called behaviors, but since it appears increasingly that the lightbox is a particular setting of the image block, we will no longer be shipping behaviors as a concept for WordPress 6.4. This means that the tracking issue for the lightbox as a behaviors MVP has now been closed.

This also means that we need to revise the lightbox UI, which is currently being discussed in Image Block: Revise Lightbox UI to Remove Reference to Behaviors.

We also finally merged aspect ratio support, which means that the lightbox now supports all single image block features.

With that in mind, implementing the new lightbox UI takes precedence over adding support for additional block types and and as a potential replacement for the attachment page, so I've revised the v0.1 and v0.2 goals and scope to reflect that prioritization.

In other words, the v0.1 will be the primary focus until it's shipped, with the v0.2 tasks being an aspirational goal for WordPress 6.4. I'll continue updating the v0.2 list of tasks as we complete the UI and the scope for those tasks becomes better defined.

Merged

Closed

artemiomorales commented 1 year ago

Biweekly Update

These past couple of weeks we've spent a lot of time discussing what the UI for the lightbox should look like for the release of the WP 6.4 beta, slated for 26 September 2023, captured in the following issue. All feedback considered, the current design we're working on is captured in this comment.

We have two open PRs to remove the old Behaviors UI and introduce new settings panels for the image in the Global Styles and block settings, which have been added to the task list for v0.1:

We're aiming to have these outstanding tasks completed by 13 September 2023, the last Gutenberg release so we can comfortably have a couple of weeks of testing before the lightbox is, if all goes well, merged to WordPress core.

annezazu commented 1 year ago

@artemiomorales where do we stand on this? I don't see a recent update in the last two weeks and I'd like to feature this in a next call for testing for the FSE Outreach Program :)

artemiomorales commented 1 year ago

@annezazu Thanks for reaching out! As far as I can see, the lightbox will be included in Gutenberg 16.7 and WP 6.4, so yes having more eyes on it would be great 😄 Here follows a more detailed update:

Biweekly Update

We've removed the old UI for the lightbox and added its new UI as an exclusive setting for the image block. This means that the lightbox, barring any unforeseen circumstances, will be shipped in WordPress 6.4.

While implementing the UI changes, we noticed some inconsistency in how theme.json settings are accessed and parsed in the codebase, so while the new UI will work without issue in a majority of cases, certain theme.json values will cause unexpected behavior under certain circumstances.

As beta testing commences, we'll continue to refine this and fix any other bugs that arise throughout the beta period over the next few weeks, as well as add tests. These new action items have been added to the v0.1 scope.

Merged

Closed

bph commented 1 year ago

@artemiomorales It all works fine. h owever, maybe you can elaborate on this with one or two examples (or point to the educating issue)

certain theme.json values will cause unexpected behavior under certain circumstances.

artemiomorales commented 1 year ago

@bph Thank you for taking a look at this! We've captured the theme.json inconsistencies in the following issues. The v0.1 task list has also been updated with these links.

annezazu commented 1 year ago

Marking this as blessed for major release per this slack discussion. @artemiomorales can you confirm that would be desirable? It seems like we'll likely get everything in in time for beta :) We can easily remove the status and we do try to keep those marked as blessed small in number.

artemiomorales commented 1 year ago

@annezazu Yes that sounds good! We'll likely merge a couple of more enhancements before the beta period is over, so this sounds right.

artemiomorales commented 1 year ago

Biweekly Update

These past two weeks, we've been reporting and fixing bugs to prepare for WordPress 6.4 — a huge thanks to everyone who has been helping with testing 🙏

Worth noting: We've clarified the scope regarding which theme.json issues we'll address and fixed a layout shift occurring with the zoom.

Specifically with the theme.json, for now the plan is to add top-level setting support for the lightbox but not add support for the shorthand syntax.

Given the newly reported bugs, I've updated the target date for v0.1 to be October 17th, the projected date for the WordPress 6.4 Release Candidate 1. I've added the new bugs to the scope.

Merged

Bugs added to the v0.1 scope

The plan is to continue addressing bugs, do more testing, and add automated tests.

artemiomorales commented 1 year ago

Biweekly Update

These past two weeks we've been wrapping up outstanding bugs to get the lightbox included in 6.4. Having more eyes on this continues to be great as folks chip in with identifying or fixing issues, from accessibility to backwards compatibility and more.

Closed / Merged

Remaining bugs for v0.1 scope

JosKlever commented 1 year ago

It looks like I've found a bug, but I'm not sure yet how it works. I've read a post using the new lightbox, and instead of showing the lightbox icon in the top right corner of an images on hover, it showed on 100% width/height even without the hover covering the all the images in the post with a black overlay.

This happened on both my (Windows) desktop as laptop with Chrome, Chrome incognito and Edge, but not with Firefox. All latest versions. There were no errors in the browser console and no extensions that could have blocked something,

In the end I've tested it without some local security and disabled Malwarbytes Anti-Malware. After that if worked as it should. So Malwarebytes seems to block a script or something that prevents the lightbox to work correctly.

More research is probably necessary, but I'll have to do that later. If this is not the right place to report it, please let me know where it belongs.

artemiomorales commented 1 year ago

It looks like I've found a bug, but I'm not sure yet how it works. I've read a post using the new lightbox, and instead of showing the lightbox icon in the top right corner of an images on hover, it showed on 100% width/height even without the hover covering the all the images in the post with a black overlay.

@JosKlever Thanks for your comment, and pardon the delay!

Would you be able to file a bug report? That will give the issue more visibility and allow folks to try to reproduce it, discuss, and suggest solutions 😄

JosKlever commented 1 year ago

@artemiomorales The issue appears to be solved now. I guess there was an update in the last 10 days that fixed it.

artemiomorales commented 1 year ago

Biweekly Update

I'm a bit late on this update, but it looks like the lightbox has made it to WordPress 6.4.

Once 6.4 is released, we hope to receive more feedback on the implementation and continue iterating our approach.

This seems to be a good milestone, so I think we can declare the v0.1 of the lightbox done; I've moved remaining tasks to v0.2 and will continue developing the scope of work for 6.5 there.

For the moment, these are the next issues we'll be tackling:

Thanks everyone for your help in getting the lightbox to this stage of development! 🙌 🥳

artemiomorales commented 12 months ago

Update

Hey everyone, here I'm shooting an update to let everyone know that I'll be away until the week of December 4th and that biweekly updates may pause until I'm back.

Please reach out to @michalczaplinski on any issues or for any questions and discussions pertaining to the lightbox in the meantime. Thank you!

NicoHood commented 11 months ago

Will the lightbox be also added to the text+media block? I did not find it in this roadmap.

michalczaplinski commented 11 months ago

There are no short-term plans to do that as far as I'm aware, but I'd very happily review any PRs that add it! It might be a bit tricky because the Media&Text block can have different alignment configurations.

artemiomorales commented 9 months ago

Update

Hello all! Since the last update, my focus has mostly shifted to another project for 6.5, and someone else may be overseeing the lightbox come 6.6.

For the moment, I'm aiming to deliver just an improved UX for the lightbox in 6.5 via the following PR, as well as deal with any critical bugs if they arise:

Please feel free to continue reporting bugs and suggesting improvements; if you mention this issue, I can add those items to the backlog here for reference 🙏