WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.52k stars 4.21k forks source link

Tips: Unclear icon and icon insufficient color contrast ratio #51705

Open afercia opened 1 year ago

afercia commented 1 year ago

Description

The Tip component is used mainly in the Main inserter, to show some 'tips' to users.

By default, it uses a decorative 'tip' icon with a yellow/orangish color.

Screenshots:

Screenshot 2023-06-20 at 13 07 08

In other places in the UI, the external link icon inherits color from the surrounding text by the means of the CSS property fill: currentColor;:

Screenshot 2023-06-20 at 15 53 53

Instead, the Tip external link icon color is overridden by a CSS rule with a higher specificity:

.components-tip svg {
    fill: #f0b849;
    align-self: center;
    flex-shrink: 0;
    margin-right: 16px;
}

Step-by-step reproduction instructions

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

afercia commented 1 year ago

To see more Tips occurrences, just scroll the main inserter and observe its bottom part. Some 'global tips' are shown there, randomly. As an aside: I wonder how much these tips are discoverable:

Screenshot 2023-06-20 at 15 33 20