search

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.25k stars 4.09k forks source link

Replace forked mobile editor dependencies #53359

Open dcalhoun opened 1 year ago

dcalhoun commented 1 year ago

This issues tracks various tasks for removing forked, third-party dependencies for the native mobile editor. The following tasks could likely be addressed individually as miniature projects.

What problem does this address?

The forked dependencies have caused issues in the past, e.g. https://github.com/WordPress/gutenberg/issues/33424, https://github.com/WordPress/gutenberg/issues/40540. We have adapted our approach to work around these issues, but the forked dependencies remain an inefficiency.

Current State

Dependency Modify iOS Modify Android Modify Javascript Removal Difficulty
react-native-reanimated ✅[^1]     Low
~react-native-prompt-android~   ~✅~   ~High~
react-native-video   ✅ ✅ High
react-native-slider ✅   ✅ Low
~react-native-hsv-color-picker~     ✅~ ~Medium~

What is your proposed solution?

We could remove dependency on the forked dependencies by committing fixes/required changes to the upstream repositories or internalizing the dependency in the form of implementing the dependency in the Gutenberg code directly.

[^1]: The modification is made to Podfile to fix an actual issue from the upstream repository.

dcalhoun commented 11 months ago

Noting that react-native-prompt-android was removed in https://github.com/WordPress/gutenberg/pull/54096.