search

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.45k stars 4.17k forks source link

Improve experience of opening and tabbing to Settings #53444

Open annezazu opened 1 year ago

annezazu commented 1 year ago

In 15:53 of a WordPress 6.3 Accessibility overview, @alexstine shows how, after opening settings, it still takes a few tab stops to get to the actual settings! “This is an anti-pattern and it should not ever happen.” I agree that this is painful. How can we iterate @WordPress/gutenberg-design ?

jasmussen commented 1 year ago

Thank you for the report, let's definitely get this to a good place. Presumably the sidebar API that plugins can tap into suffers from the same problem.

I'm curious if the List View suffers from a similar problem, from my testing it seems like opening the list view transfers focus there. Is that potentially a pattern we can leverage here?

alexstine commented 1 year ago

@jasmussen That is a good pattern to use but a better pattern to use is having the button that controls the sidebar actually appear in the DOM near the sidebar it controls. This is a classic case of over engineering. We shouldn't need to move focus so much if the editor simply had a better flow, DOM speaking.

jasmussen commented 1 year ago

Thanks again. Sounds like there are two valid approaches going forward, and the "move it to the DOM" is the preferred one. I'll add the "needs dev" tag to see if we can move that forward.