WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.53k stars 4.21k forks source link

Fonts: Switching style variations unchecks active fonts #54985

Open annezazu opened 1 year ago

annezazu commented 1 year ago

Description

After uploading and activating a font, if you switch to a different style variation, the same uploaded font variations are de-selected, essentially removing the font from being selected and requiring you to re-activate each variant. cc @matiasbenedetto

Video

https://github.com/WordPress/gutenberg/assets/26996883/9174c0ad-b7c4-4a47-a280-525539dd0ba2

Environment

matiasbenedetto commented 1 year ago

Thanks for reporting this, but currently, this is the expected behavior. When a user switches global styles, the theme.json of the style variant file is saved as the content of global styles post in the database. The active installed fonts are stored in global styles, so when the switch happens, the active fonts (as all the other elements stored in global styles) are replaced by the content of the style variation theme.json data. To change this behavior, we would need to change how the style variations work in a non-standard way. I think we can think more about this in the future, but for now, I think is not a priority in the refinements needed by the font library.

I'm removing the bug label. @annezazu I suggest to remove it from the 6.4 board.

annezazu commented 1 year ago

Fantastic! Thank you. Removed and added the enhancement label.

annezazu commented 9 months ago

After a review by core editor triage leads and core editor tech leads, this has been punted for consideration to 6.6. This doesn't mean it'll for sure make it into the 6.6 release to be clear!

colorful-tones commented 6 months ago

Hi folks, We are only one week away from the Beta 1 cut-off date for WordPress 6.6. This issue hasn’t seen any movement in a while, so we (the editor triage leads of the 6.6 release) have decided to remove it from the WordPress 6.6 Editor Tasks project board.