Open annezazu opened 1 year ago
As a conversation has continued over in both this PR to replace the Aa icon with text and an issue to replace the Aa icon with text, I wanted to bring in a current design proposal to discuss and move forward for WordPress 6.5:
I think there's potential to refine the Aa icon itself to better represent typography, but the cog icon is already widely used. We could potentially replace it with a plus, or an ellipsis. The thing is, once you have fonts, the management stuff is secondary (or even tertiary) in importance.
What we can do is add this button when there are no fonts installed, like so:
The feedback about the above proposed design highlights how Aa icon remains unclear to leave in place after fonts are installed. One can imagine a situation where they click Typography > Add Fonts > they add a font > and then they are unable to understand where to go next to manage those fonts. While it's not necessarily something of primary importance, discoverability and that initial drop off are (still) coming up as points of feedback. @t-hamano suggested adding using the edit pencil button that appears throughout the site editor interface to communicate the ability to edit something a next step.
What iterations can be done as feedback and various solutions are being explored?
cc @afercia @jasmussen @richtabor @t-hamano @carolinan @earnjam
The following are showing various icons that can be used instead of a new icon, which seems to be part of what's causing confusion. After someone installed fonts, this icon is what would then be used to manage them. This feels like it strikes a good balance of familiarity throughout the interface and matches the level of importance (installing fonts primary vs managing fonts lower). The key is figuring out which works best.
Edit Pencil icon Here's a look at the above design with a change in icon to be the edit pencil as that matches what we have right now for edit styles in the Site Editor.
https://github.com/WordPress/gutenberg/assets/26996883/09bdd9be-19c7-4562-9594-767c90a7f5da
This matches what @t-hamano suggested before!
+ button icon
Another option that @richtabor brought up as we were chatting about this is the + button, which matches what's in place for colors:
https://github.com/WordPress/gutenberg/assets/26996883/e8b9b87a-5e6c-4c11-a42d-4fc92b99597e
Settings icon
@richtabor also brought up the settings icon which might better reflect the "manage" aspect:
https://github.com/WordPress/gutenberg/assets/26996883/10249f87-91b0-43c8-a07f-883546d5a097
Summary
Finally, wanted to note this issue around discoverability by adding a command to the command palette to open up fonts as well which should also help https://github.com/WordPress/gutenberg/issues/54880
I like the settings icon when there are fonts; + icon when there are not. It's already familiar and expected.
My feelings about each icon are as follows, and I prefer the edit
icon.
edit
: In the Font Library, we can activate, deactivate, install, and delete fonts. So, if fonts already exist, I think this icon is the closest to the context in the context of "edit".
cog
: This icon feels a bit exaggerated, as it represents a more global level or app-wide “setting”.
plus
: If we don't have any fonts, we should always start by installing them. This icon seems to make sense if we don't want to display a button with text like "Add Fonts".
settings
: This icon is used to change query conditions in the query block and toggle custom size input in the block sidebar. This icon seems to have a strong meaning as "settings" rather than "edit" to me. I feel that the role of the font library is closer to "edit" than "settings".
Based on this, I would like to propose the following new experience.
https://github.com/WordPress/gutenberg/assets/54422211/7c891f2c-c392-455b-860c-ddf42cac0c71
Alternatively, we might want to display the text "No fonts installed" and a plus icon if no fonts are available.
I like the settings icon when there are fonts; + icon when there are not. It's already familiar and expected.
I'm not sure changing icon conditionally would contribute to UI clarity and help users.
Based on this, I would like to propose the following new experience.
If the font does not exist, display a button with the text "Add font". No icon is displayed. It also doesn't display the text "No fonts installed". Displays the edit icon if the font exists. The button with text is not displayed.
I would have preferred to not use button icons at all. Ideally, these kind of alternative design choices should just be A-B tested with a group of testers of diverse abilities instead of being left to personal argumentation. In absence of user testing, there's prior research and guidelines to follow. They all highlight that icon-only controls have inherent accessibility problems. From designers in this project I expect accessible and inclusive design.
That said, if there is a strong opposition to using buttons with visible text, I'd then second @t-hamano proposal so that we'll use at least one button with visible text 😄
Relevant feedback about this issue has been reported also on https://github.com/WordPress/gutenberg/issues/58082 which brings in accessibility considerations too. Please take into consideration feedback and proposal from that issue.
I agree that the icon as it exists is not ideal and located in an odd place.
After reading through #58082 and this issue (55179). I think @afercia is on to something here:
I think we should strive for consistency and establish a new pattern for all buttons that open a modal dialog. If it was up to me, I'd place a 'Manage all fonts' button at the end of the fonts list. Something like what is illustrated in the following example screenshot:
The simplest solution, that aligns with existing user expectations/experience in the editor, would be to use the settings icon in place of the Aa
icon. I say we try this.
I've implemented those two suggestions in https://github.com/WordPress/gutenberg/pull/58580.
Let's leave this open as a place to gather feedback with the above changes in place, especially as we head into beta 1 and inevitably more feedback is likely to come into play with a chance to possibly iterate again or keep as is.
Moved to "done" for now purely for organizational purposes to focus remaining efforts on items that haven't had attention or that need more urgent iteration.
The simplest solution, that aligns with existing user expectations/experience in the editor, would be to use the settings icon
I'm no sure I understand the statement that using the settings icon 'aligns with existing user expectations', when the actual users feedback that comes from the FSE Outreach Program reports the opposite. Feedback from other contributors and accessibility specialists also reported that this feature is very little discoverable and an icon isn't sufficient.
I'd like to bring in one more consideration. The Font Library is one of the most important new features in WordPress 6.5. It's probably _the most awaited feature in 6.5.
I'm not sure that hiding the fonts management behind a small, pretty obscure, icon is ideal from a product management perspective in the first place. One more reason to make this feature more prominent by using a button with visible text.
Hi folks, We are only one week away from the Beta 1 cut-off date for WordPress 6.6. This issue hasn’t seen any movement in a while, so we (the editor triage leads of the 6.6 release) have decided to remove it from the WordPress 6.6 Editor Tasks project board.
Think we can just mark this as closed by https://github.com/WordPress/gutenberg/pull/58580. If the UI needs more work then I'm sure we'll hear about it in a new issue.
I'm not sure this issue should be closed, as there's still improvements to consider.
https://github.com/WordPress/gutenberg/pull/58580 only made improvements when there's no font installed. However, when there are fonts installed, teh UI isn't clear. See screenshot:
The 'settings' icon doesn't tell me that's the place to open the Manage fonts modal dialog at all.
More importantly, there's still direct feedback from users coming from the FSE Outreach Program that hasn't been addressed yet.
In https://github.com/WordPress/gutenberg/issues/58082 there's a clear proposal to add a 'Manage all fonts' button at the end of the fonts list that hasn't been addressed.
As such, I'm reopening this issue for further consideraiton.
I noticed one more detail that should be reconsidered and I'd call it an UX flow bug. When a theme doesn't provide any font and there's no custom fonts installed, the 'Manage fonts' icon button opens the modal dialog and shows the 'Library' tab, which is empty. There's no great point in bringing users to an empty tab where they can't do anything. In this scenario, only the 'Add fonts' button makes sense. The 'Manage fonts' doesn't, as there's nothing to manage. I noticed there's also an e2e test about this scenario that appears to be based on a wrong assumption.
I'm reopening this issue after the revert in https://github.com/WordPress/gutenberg/issues/65574
This issue was created after direct feedback from users who were confused by the fonts list and couldn't find an easy way to 'manage all fonts'. An attempt to provide a clearer UI was tried in https://github.com/WordPress/gutenberg/pull/62129 and then reverted in https://github.com/WordPress/gutenberg/issues/65574 based on personal opinions and with no user testing at all.
Now, a few days after the WordPress 6.7 release, users are reporting again they are confused by the fonts lists UI. See:
https://github.com/WordPress/gutenberg/issues/65574#issuecomment-2481431862 https://wordpress.org/support/topic/manage-fonts-not-showing/
For the future, I would greatly appreciate any UI design to take into account users feedback over personal opinions. Keeping ignoring direct feedback from users doesn't seem the best way to provide a clear, easy to use user interface. Thanks.
I'd encourage the design team to provide a new design and solve the underlying source of confusion in this UI. Cc @WordPress/gutenberg-design
For the future, I would greatly appreciate any UI design to take into account users feedback over personal opinions. Keeping ignoring direct feedback from users doesn't seem the best way to provide a clear, easy to use user interface. Thanks.
100%. And I'd appreciate if we propose solutions that do not further complicate, nor deviate, from the existing conventions of our application. Otherwise they will not be approved.
Also, for https://wordpress.org/support/topic/manage-fonts-not-showing/, rendering the manage fonts button will not resolve the user's confusion. It's unrelated. Instead it's confusion about expectations.
This is very confusing. If on the Fonts listing, there is an option to manage the fonts, but in reality the fonts in a typeset can’t be changed, why show the option?
and both of these are the same: https://github.com/WordPress/gutenberg/issues/65574#issuecomment-2481431862 https://wordpress.org/support/topic/manage-fonts-not-showing/
No, that comment was written after I pointed out to the user where the option was, with a screenshot. Here is a quote from their first post:
When you go to the Typography section, there is no Manage fonts option.
No, that comment was written after I pointed out to the user where the option was, with a screenshot.
It does not change what their intentions were, and what they were confused about. Adding a button there would result in the same core question.
There is more than one problem. This issue is about making the library more discoverable.
solutions that do not further complicate, nor deviate, from the existing conventions
Have you considered that the 'existing conventions' may be just wrong? 🙂 That's not a good argument.
To me, a few conventions need to be established here:
All this points have already been discussed, this is just a recap. Regardless of personal opinions presented as unshakeable truths, the point is that there's again direct feedback from users that this UI is unclear and confusing.
https://github.com/WordPress/gutenberg/pull/62129 was an attempt to make the UI clearer. I'm not pretending it was perfect, but it was better. The argument that it was not inline with existing conventions is close to a personal opinion. To me, that means the existing conventions should be likely audited and rediscussed.
Users don't understand this UI. Ignoring users feedback isn't in line with the WordPress tradition and openness to users' feedback and the commitment to provide an easy-to-use UI. As such, I think the revert was an unfortunate decision made without any effort to gather consensus.
Pulling in feedback from the FSE Outreach Program's Final Touches call for testing:
I've heard this from a few folks at this point and it's clear that this feature isn't easily discoverable. Perhaps we could consider it as part of iteration for design details: https://github.com/WordPress/gutenberg/issues/53483 but for now I wanted to open an issue to gather this feedback.